Skip to content

Conversation

@ndelangen
Copy link
Member

Closes #32892

What I did

Rename the experimental framework in the eslint plugin

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

…and remove deprecated '@storybook/experimental-nextjs-vite'
@ndelangen ndelangen changed the title Update no-renderer-packages rule to include '@storybook/nextjs-vite' and remove deprecated '@storybook/experimental-nextjs-vite' ESlint: Update '@storybook/experimental-nextjs-vite' in no-renderer-packages rule Oct 31, 2025
@ndelangen ndelangen changed the title ESlint: Update '@storybook/experimental-nextjs-vite' in no-renderer-packages rule ESlint: Update @storybook/experimental-nextjs-vite in no-renderer-packages rule Oct 31, 2025
@ndelangen ndelangen self-assigned this Oct 31, 2025
@ndelangen ndelangen added bug patch:yes Bugfix & documentation PR that need to be picked to main branch ci:normal eslint-plugin labels Oct 31, 2025
@nx-cloud
Copy link

nx-cloud bot commented Oct 31, 2025

View your CI Pipeline Execution ↗ for commit 999677f

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 45s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-31 11:59:13 UTC

@ndelangen ndelangen merged commit 07ec72d into next Oct 31, 2025
59 of 61 checks passed
@ndelangen ndelangen deleted the norbert/remove-reference-to-removed-framework branch October 31, 2025 12:02
ndelangen added a commit that referenced this pull request Nov 3, 2025
…o-removed-framework

ESlint: Update `@storybook/experimental-nextjs-vite` in `no-renderer-packages` rule
(cherry picked from commit 07ec72d)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug ci:normal eslint-plugin patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: eslint-plugin-storybook no-renderer-packages references @storybook/experimental-nextjs-vite

2 participants