-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Vitest Addon: Add support for Preact #32948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
View your CI Pipeline Execution ↗ for commit f557f7f
☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit 7785262
☁️ Nx Cloud last updated this comment at |
📝 WalkthroughWalkthroughRegistered '@storybook/preact-vite' as a supported framework for the Vitest addon, removed Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Notes for reviewer:
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🧰 Additional context used🧠 Learnings (3)📓 Common learnings📚 Learning: 2025-09-17T08:11:04.287ZApplied to files:
📚 Learning: 2025-10-13T13:33:14.659ZApplied to files:
🔇 Additional comments (4)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Comment |
kylegach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs are good; thanks!
Vitest Addon: Add support for Preact (cherry picked from commit 957bb1c)
Closes #
What I did
This PR enables Preact in the testing feature of Storybook
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Initialize Storybook in a Preact project, then make sure tests can be run using the testing widget.
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>Summary by CodeRabbit
New Features
Documentation
Chores