Skip to content

CLI: In csf-factories codemod only remove types which are unused #33020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yannbf merged 11 commits into from
Nov 18, 2025
Merged

CLI: In csf-factories codemod only remove types which are unused #33020

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e062f38
CLI: In csf-factories codemod only remove types which are unused
yannbf Nov 12, 2025
63fdf93
Merge branch 'next' into yann/do-not-remove-used-types-csf-factories
yannbf Nov 12, 2025
b134cf3
Merge branch 'next' into yann/do-not-remove-used-types-csf-factories
yannbf Nov 13, 2025
82deb7a
extract and rework type removal logic
yannbf Nov 13, 2025
af2326b
use diff in test
yannbf Nov 13, 2025
6935742
try to fix flake
yannbf Nov 13, 2025
ff0e4b6
fix windows failure
yannbf Nov 13, 2025
a7bedcd
Use Norbert's AI solution
yannbf Nov 14, 2025
61612bd
Merge branch 'yann/do-not-remove-used-types-csf-factories' of github.…
yannbf Nov 14, 2025
bc61ca4
update tests
yannbf Nov 14, 2025
8ece7fd
Merge branch 'next' into yann/do-not-remove-used-types-csf-factories
yannbf Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
try to fix flake
  • Loading branch information
@yannbf
yannbf committed Nov 13, 2025
commit 6935742708a6e18da64e664c67a8943f9ccf46f9
5 changes: 3 additions & 2 deletions code/lib/cli-storybook/src/codemod/helpers/remove-unused-types.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,9 @@
};

export default { component: Button };
`;
const transformed = getTransformed(source);
`.replace(/\r\n/g, '\n');

const transformed = getTransformed(source).replace(/\r\n/g, '\n');
expect(getDiff(source, transformed)).toMatchInlineSnapshot(`
import { Button } from './Button';

Expand Down Expand Up @@ -114,6 +115,6 @@

const transformed = getTransformed(source);

expect(transformed).toEqual(source);

Check failure on line 118 in code/lib/cli-storybook/src/codemod/helpers/remove-unused-types.test.ts

View workflow job for this annotation

GitHub Actions / Core Unit Tests, windows-latest

src/codemod/helpers/remove-unused-types.test.ts > removeUnusedTypes > should not remove used Storybook types 

AssertionError: expected '// Nothing in this file should be rem…' to deeply equal '// Nothing in this file should be rem…'

- Expected
+ Received

- // Nothing in this file should be removed or modified
+ // Nothing in this file should be removed or modified
- import { StoryFn, StoryObj, ComponentStory, Meta, MetaObj, ComponentMeta } from '@storybook/react';
+ import { StoryFn, StoryObj, ComponentStory, Meta, MetaObj, ComponentMeta } from '@storybook/react';
- import { Button } from './Button';
-
+ import { Button } from './Button';
+ 
- type Alias = StoryFn<typeof Button>;
+ type Alias = StoryFn<typeof Button>;
- type Alias2 = Alias & { b: string };
+ type Alias2 = Alias & { b: string };
- type Story = StoryObj & { a: string };
+ type Story = StoryObj & { a: string };
- type DeepType = {
+ type DeepType = {
-   foo: {
+   foo: {
-     bar: {
+     bar: {
-       story: ComponentStory<typeof Button>;
+       story: ComponentStory<typeof Button>;
-     }
+     }
-   }
+   }
- };
+ };
- interface Interface extends Meta {}
+ interface Interface extends Meta {}
- interface DeepInterface {
+ interface DeepInterface {
-   baz: {
+   baz: {
-     qux: {
+     qux: {
-       meta: MetaObj<typeof Button>;
+       meta: MetaObj<typeof Button>;
-     }
+     }
-   }
+   }
- };
+ };
- const X: ComponentMeta = {}
-
+ const X: ComponentMeta = {}
+ 
- function foo(a: Story, c: DeepType, d: Interface, e: DeepInterface){}
-
+ function foo(a: Story, c: DeepType, d: Interface, e: DeepInterface){}
+ 
  export default {};

 ❯ src/codemod/helpers/remove-unused-types.test.ts:118:25
});
});
Loading