Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 18, 2025

The nx.json runtime command used Unix-specific shell syntax (cd .. && git ls-files ... | sort | ...) that fails on Windows cmd.exe.

Changes:

  • Created scripts/hash-scripts-dir.mjs: Cross-platform Node.js script using execSync() to compute git file hash
  • Updated code/nx.json: Replaced shell command with node {workspaceRoot}/../scripts/hash-scripts-dir.mjs

The script handles Windows/Unix line ending differences (\r?\n) and produces identical hash output to the original command.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] WIP Address feedback on Windows compatibility for nx update PR Fix Windows compatibility for Nx runtime cache hash Nov 18, 2025
Copilot AI requested a review from kasperpeulen November 18, 2025 13:29
Base automatically changed from kasper/nx-up to next November 18, 2025 14:22
@github-actions
Copy link
Contributor

Fails
🚫

PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","build","dependencies"]

🚫

PR is not labeled with one of: ["ci:normal","ci:merged","ci:daily","ci:docs"]

🚫 PR title must be in the format of "Area: Summary", With both Area and Summary starting with a capital letter Good examples: - "Docs: Describe Canvas Doc Block" - "Svelte: Support Svelte v4" Bad examples: - "add new api docs" - "fix: Svelte 4 support" - "Vue: improve docs"

Generated by 🚫 dangerJS against 3c1bd0c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants