-
-
Notifications
You must be signed in to change notification settings - Fork 10k
Build: Make the git root the yarn workspace root #33079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
151 commits
Select commit
Hold shift + click to select a range
1c1ffd8
Make the git root the yarn workspace root
kasperpeulen 2389161
Move nx to the root
kasperpeulen 87248f1
Fix checksums
kasperpeulen 4ed1f03
run yarn
kasperpeulen 8315eca
More fixes
kasperpeulen 60585da
dedupe
kasperpeulen 3395ec4
feat(nx-cloud): setup nx cloud workspace
kasperpeulen 90a98b1
Merge pull request #33093 from storybookjs/feat/nx-cloud/setup
kasperpeulen 191f62f
Enable nx distributed tasks
kasperpeulen 27f0df8
Enable nx distributed tasks
kasperpeulen 3f41c5c
Enable nx distributed tasks
kasperpeulen 450a597
Enable nx distributed tasks
kasperpeulen 40546dc
Run on every push
kasperpeulen c5b8f6f
Fix
kasperpeulen 4b0c692
Add pretty docs
kasperpeulen 1a4bd4b
Add cache true
kasperpeulen 3c6b896
Add node_modules to cache
kasperpeulen 8fefecc
Fix lint
kasperpeulen 201ec1d
Make it faster
kasperpeulen 7ec3ddf
Fix test command
kasperpeulen 8cbbe64
Fix package.json
kasperpeulen eb15265
Make test succeed
kasperpeulen 6bd1298
Add check command
kasperpeulen c1aad54
Fix depends on
kasperpeulen 9b026ad
Install jiti
kasperpeulen 8d8340f
Fix esbuild path
kasperpeulen 4541ed1
Fix yarn.lock
kasperpeulen f156b7c
Fix chromatic build
kasperpeulen f043740
Fix jiti
kasperpeulen 94e0fb1
Fix jiti?
kasperpeulen 0c7f833
Fix deps
kasperpeulen 97703ea
Fix check finally
kasperpeulen 21f36b4
Fix check finally
kasperpeulen 22d4943
Fix check
kasperpeulen c1f1d14
Fix
kasperpeulen 7f591cb
Add sandboxes to nx cloud
kasperpeulen 5b5707d
Make it faster
kasperpeulen 29e4e62
Fix
kasperpeulen d58145b
Only ci-daily
kasperpeulen b725865
Run chromatic
kasperpeulen 5b8cc5d
Run chromatic
kasperpeulen 43b867d
Fix job
kasperpeulen 31b66f3
Fix job
kasperpeulen ada652d
Fix run-registry
kasperpeulen d117b55
Fix
kasperpeulen fc43625
Run e2e-tests
kasperpeulen 64445d9
Fix
kasperpeulen 5c69f66
Fix
kasperpeulen b95a58c
Fix
kasperpeulen 6510728
Fix knip
kasperpeulen 1dafa76
Fix e2e tests
kasperpeulen 87aeefa
Fix e2e tests
kasperpeulen 749d6e7
Run scripts and root as well
kasperpeulen 96a5985
Fix prodution config
kasperpeulen b1da823
Fix never to never run dependent tasks
kasperpeulen 9432c9d
Add check-sandbox
kasperpeulen f4a7b3f
More
kasperpeulen 343fc35
Fix never
kasperpeulen 34a86cb
Add env variables
kasperpeulen efd1c71
Fix error message
kasperpeulen 48062e6
Fix
kasperpeulen 7480c35
Fix sandbox parts
kasperpeulen 4b48623
Fix ports
kasperpeulen bfa1030
Fix nx
kasperpeulen df5833b
Fix knip
kasperpeulen 9070aa0
Fix projects
kasperpeulen f4f1400
Fix yarn.lock
kasperpeulen b461426
Fix e2e tests
kasperpeulen aa067dd
Fix e2e tests
kasperpeulen fda45b4
Fix this shit
kasperpeulen 84b4c6f
Add allmost everything to nx
kasperpeulen aa22dec
Add test-storybooks commands
kasperpeulen 7954641
Fix
kasperpeulen e4a4e44
Fix sandbox command
kasperpeulen f9f9013
Fix yarn immutable
kasperpeulen 0b0d57c
Fix stop-agents
kasperpeulen 73f17ad
Add all test storybook tests
kasperpeulen 25f522c
Some last fixes
kasperpeulen 603ae01
Some last fixes
kasperpeulen 2e4f5fe
Cleanup
kasperpeulen ee68eed
Remove svelte skeleton for now
kasperpeulen da41a2b
Don't store sandbox in nx cache
kasperpeulen 26037e4
Log
kasperpeulen cd89923
Remove yarn cache as well
kasperpeulen 981cb9f
Depend on run-registry
kasperpeulen 20b6013
Wait on registry
kasperpeulen 5fc9f20
Fix yarn issues
kasperpeulen 8a14b20
Timeout
kasperpeulen 178fba9
Better kill ports
kasperpeulen c4c70a1
Fix logic
kasperpeulen 1d4b4c6
Better messing around
kasperpeulen 344e2d6
Fix killing
kasperpeulen 9f30b36
Never close verdaccio
kasperpeulen c94550f
Fix verdaccio
kasperpeulen 117269b
Fix
kasperpeulen 125b82f
Fix
kasperpeulen bbfdc18
Fix
kasperpeulen cc98663
Fix it for real
kasperpeulen ae66276
Use promise
kasperpeulen d603f3b
detach local-registry
kasperpeulen 8015e38
Fix
kasperpeulen 4cdcbf2
Fix
kasperpeulen 1cefa8a
Fix
kasperpeulen 8aa1061
Fix
kasperpeulen 9933662
Fix
kasperpeulen 3f32b93
Add call to setUnready function
kasperpeulen 065723e
Try out
kasperpeulen 39bf94a
Merge remote-tracking branch 'origin/kasper/ai-friendly-setup' into k…
kasperpeulen a660e75
Fix
kasperpeulen 84efc7c
Fix prepare sandbox
kasperpeulen caa4293
Fix prepare sandbox
kasperpeulen 403d286
Fix prepare sandbox
kasperpeulen ff88872
Debug better
kasperpeulen 561c6a2
Fix
kasperpeulen dc21f51
Fix
kasperpeulen 24a2fcf
More debugging
kasperpeulen 24f5f1a
Fix
kasperpeulen 3c5df2d
More log information
kasperpeulen 1047610
debug further
kasperpeulen 1ea7956
Update dependencies for prepare sandbox command
kasperpeulen 1d7ed0a
Fix
kasperpeulen c0b2f83
Custom agent
kasperpeulen 2956855
Start verdaccio in background
kasperpeulen c601e3a
Always start fresh
kasperpeulen 8bcf839
Killing ports
kasperpeulen 6d24960
Try differntly
kasperpeulen dea058e
Remove
kasperpeulen 15211b2
Fix test
kasperpeulen 80af299
Fuckers
kasperpeulen df4a27c
Wait longer
kasperpeulen 5205f7e
Fix
kasperpeulen 058fcd3
Merge remote-tracking branch 'origin/next' into kasper/ai-friendly-setup
kasperpeulen b4dd932
yarn.lock
kasperpeulen 8a07044
Fix
kasperpeulen e8ecfd6
Merge remote-tracking branch 'origin/next' into kasper/ai-friendly-setup
kasperpeulen d450284
dedupe
kasperpeulen c19f881
Fix pretty docs
kasperpeulen 0eda2f9
Fix pretty docs
kasperpeulen f37eaf4
Fix
kasperpeulen 0bcff4b
Fix
kasperpeulen 7955c88
Fix
kasperpeulen bef07e7
Fix
kasperpeulen 86ecf6e
Revert
kasperpeulen 3f52a5a
Fix
kasperpeulen ca872c3
Fix
kasperpeulen a9483c7
Run sandboxes outside of git repo in circle ci
kasperpeulen 38d10a7
Fix
kasperpeulen 07d59d1
Fix
kasperpeulen 1ead2a8
Increase timeout
kasperpeulen 7dd976b
Increase timeout
kasperpeulen 74699b7
Fix circle ci
kasperpeulen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix
- Loading branch information
commit c1f1d1466ce904a618771943476e4d729d34c607
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,9 @@ | ||
| { | ||
| "name": "angular", | ||
| "$schema": "../node_modules/nx/schemas/project-schema.json", | ||
| "$schema": "../../../node_modules/nx/schemas/project-schema.json", | ||
| "projectType": "library", | ||
| "targets": { | ||
| "build": {}, | ||
| "check": { | ||
| "command": "echo '\"nx check angular\" can only run with the parameter \"-c production\", we need to expand code/storybook/storybook/scripts/prepare/check.ts'", | ||
| "configurations": { | ||
| "production": { | ||
| "cwd": "{projectRoot}", | ||
| "command": "yarn check" | ||
| } | ||
| } | ||
| } | ||
| "check": {} | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,21 @@ | ||
| { | ||
| "name": "svelte", | ||
| "$schema": "../node_modules/nx/schemas/project-schema.json", | ||
| "$schema": "../../../node_modules/nx/schemas/project-schema.json", | ||
| "projectType": "library", | ||
| "targets": { | ||
| "build": {}, | ||
| "check": {} | ||
| "check": { | ||
| "executor": "nx:run-commands", | ||
| "options": { | ||
| "cwd": "{projectRoot}", | ||
| "command": "svelte-check" | ||
| }, | ||
| "dependsOn": [ | ||
| { | ||
| "projects": ["*"], | ||
| "target": "build" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,21 @@ | ||
| { | ||
| "name": "vue3", | ||
| "$schema": "../node_modules/nx/schemas/project-schema.json", | ||
| "$schema": "../../../node_modules/nx/schemas/project-schema.json", | ||
| "projectType": "library", | ||
| "targets": { | ||
| "build": {}, | ||
| "check": { | ||
| "command": "echo '\"nx check vue3\" can only run with the parameter \"-c production\", we need to expand code/storybook/storybook/scripts/prepare/check.ts'", | ||
| "configurations": { | ||
| "production": { | ||
| "cwd": "{projectRoot}", | ||
| "command": "yarn check" | ||
| "executor": "nx:run-commands", | ||
| "options": { | ||
| "cwd": "{projectRoot}", | ||
| "command": "vue-tsc --noEmit" | ||
| }, | ||
| "dependsOn": [ | ||
| { | ||
| "projects": ["*"], | ||
| "target": "build" | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,6 +16,9 @@ | |
| } | ||
| } | ||
| }, | ||
| "tui": { | ||
| "autoExit": true | ||
| }, | ||
| "targetDefaults": { | ||
| "build": { | ||
| "executor": "nx:run-commands", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Verify schema path reflects the new workspace structure.
The schema path has been updated from
../../to../../../, which suggests the Nx schema location has moved relative to this file. This is consistent with the PR goal of consolidating to a root workspace, but ensure this path is correct for the new directory structure.🏁 Script executed:
Length of output: 840
I need to investigate the directory structure to understand why vue3 and svelte have a different path than other renderers.
Let me verify the actual directory structure to calculate the correct relative path.
🏁 Script executed:
Length of output: 992
Fix schema path inconsistency: vue3 and svelte use
../../../while other 5 renderers use../, despite being at the same directory depth.All renderers reside under
code/renderers/X/(same structural depth), but the schema paths diverge:"../node_modules/nx/schemas/project-schema.json""../../../node_modules/nx/schemas/project-schema.json"From
code/renderers/vue3/, the correct path to the repo root is../../../, so vec3's current path is mathematically correct; however, this inconsistency with other renderers suggests either:../../../node_modules/...(fixing the other 5)Verify whether this PR also updates the other renderer project.json files, or whether vec3 and svelte should revert to the
../pattern to maintain consistency.🤖 Prompt for AI Agents