Skip to content

React: Add isPackage flag to component imports for better package identification #33090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kasperpeulen merged 8 commits into from
Nov 25, 2025
Merged

React: Add isPackage flag to component imports for better package identification #33090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0354718
React: Add isPackage flag to component imports for better package ide…
kasperpeulen Nov 19, 2025
a3b196a
Update code/renderers/react/src/componentManifest/getComponentImports.ts
kasperpeulen Nov 19, 2025
41112e7
improve logic
kasperpeulen Nov 19, 2025
dee069b
Fix tests
kasperpeulen Nov 19, 2025
449a022
Update code/renderers/react/src/componentManifest/getComponentImports.ts
kasperpeulen Nov 19, 2025
3d2ce4a
Update tests
kasperpeulen Nov 19, 2025
f6174c8
Merge remote-tracking branch 'origin/kasper/next' into kasper/next
kasperpeulen Nov 19, 2025
e84b50c
Fix
kasperpeulen Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions code/renderers/react/src/componentManifest/fixtures.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export const fsMocks = {

/**
* Primary UI component for user interaction
* @import import { Button } from '@design-system/components/Button';
* @import import { Button } from '@design-system/components/override';
*/
export const Button = ({
primary = false,
Expand Down Expand Up @@ -60,7 +60,6 @@ export const fsMocks = {
/**
* Description from meta and very long.
* @summary Component summary
* @import import { Header } from '@design-system/components/Header';
*/
const meta = {
component: Header,
Expand All @@ -85,9 +84,6 @@ export const fsMocks = {
onCreateAccount?: () => void;
}

/**
* @import import { Header } from '@design-system/components/Header';
*/
export default ({ user, onLogin, onLogout, onCreateAccount }: HeaderProps) => (
<header>
<div className="storybook-header">
Expand Down
13 changes: 5 additions & 8 deletions code/renderers/react/src/componentManifest/generator.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ test('componentManifestGenerator generates correct id, name, description and exa
"description": "Primary UI component for user interaction",
"error": undefined,
"id": "example-button",
"import": "import { Button } from \"@design-system/components/Button\";",
"import": "import { Button } from "@design-system/components/override";",
"jsDocTags": {
"import": [
"import { Button } from '@design-system/components/Button';",
"import { Button } from '@design-system/components/override';",
],
},
"name": "Button",
Expand All @@ -38,7 +38,7 @@ test('componentManifestGenerator generates correct id, name, description and exa
"actualName": "Button",
"definedInFile": "./src/stories/Button.tsx",
"description": "Primary UI component for user interaction
@import import { Button } from '@design-system/components/Button';",
@import import { Button } from '@design-system/components/override';",
"displayName": "Button",
"exportName": "Button",
"methods": [],
Expand Down Expand Up @@ -143,11 +143,8 @@ test('componentManifestGenerator generates correct id, name, description and exa
"description": "Description from meta and very long.",
"error": undefined,
"id": "example-header",
"import": "import { Header } from \"@design-system/components/Header\";",
"import": "import { Header } from "some-package";",
"jsDocTags": {
"import": [
"import { Header } from '@design-system/components/Header';",
],
"summary": [
"Component summary",
],
Expand All @@ -157,7 +154,7 @@ test('componentManifestGenerator generates correct id, name, description and exa
"reactDocgen": {
"actualName": "",
"definedInFile": "./src/stories/Header.tsx",
"description": "@import import { Header } from '@design-system/components/Header';",
"description": "",
"exportName": "default",
"methods": [],
"props": {
Expand Down
Loading