Release: Prerelease 10.1.0-alpha.13 #33094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clean up type definitions - Changed framework property in FrameworkDetectionResult to be required instead of optional. - Updated getFramework method to throw an error if a framework cannot be found, improving error handling. - Removed unused type definition for Builder in project_types.ts to streamline code.
…work handling and type definitions - Updated generatorOptions to include framework and renderer properties for better configuration. - Simplified the getFrameworkDetails function to improve clarity and error handling. - Removed unused builder details logic to streamline the baseGenerator function. - Adjusted types in GeneratorOptions to reflect the new structure.
- Removed the externalFrameworks function to simplify framework detection logic. - Updated getFrameworkDetails to enhance clarity by directly applying the require wrapper on the framework package. - Improved overall readability and maintainability of the baseGenerator code.
- Added a prompt to ask users if they want to use Compodoc for documentation in Angular projects. - Improved user experience by providing information about the benefits of Compodoc. - Updated the logic to determine Compodoc usage based on user input instead of a fixed feature flag.
… addon configuration - Updated the `doInitiate` function to pass `projectType` to user preferences and generator execution. - Simplified the `executeGeneratorExecution` function to accept a single options object. - Enhanced the `UserPreferencesCommand` to determine selected features based on project type. - Adjusted addon configuration logic to utilize `extraAddons` from generator execution results. - Improved overall code readability and maintainability by streamlining function signatures and logic.
…turn structure - Updated the `GeneratorExecutionResult` type to improve clarity and structure by formatting the return type. - Adjusted the return statement in `executeProjectGenerator` to conditionally include `configDir` based on the generator result. - Improved overall readability and maintainability of the `GeneratorExecutionCommand` class.
- Updated the logging in `useStatics` to display relative paths for static directories instead of absolute paths, enhancing clarity. - Removed unused `Builder` type imports and replaced them with `SupportedBuilder` in various files to improve type consistency and maintainability.
- Replaced string literals with SupportedBuilder constants in the AddonManager test cases for improved type safety and consistency. - Enhanced clarity in the tests by using the defined types for builder options.
…aths - Updated the `useStatics` function to utilize `getProjectRoot` for calculating relative static directory paths, enhancing accuracy in logging. - Changed the logger to use `CLI_COLORS` for improved visual consistency in log messages.
- Consolidated the logging message in the `promptForCompoDocs` function to a single line for better clarity and maintainability. - Enhanced user experience by providing a concise message about the benefits of using Compodoc for documentation in Angular projects.
- Included the `yes` option in the `GeneratorExecutionCommand` to allow automatic confirmation for prompts. - Enhanced the command's flexibility by enabling users to bypass interactive prompts based on their preferences.
- Updated postinstall function to accept logger and prompt from options. - Enhanced ClackPromptProvider to manage task logging more effectively. - Streamlined logger usage in add and postinstallAddon functions. - Removed redundant task messages in baseGenerator for cleaner output.
- Removed leading arrows from logger messages in various files to standardize output format. - Introduced ConsoleLogger and StyledConsoleLogger classes for enhanced logging functionality. - Added new console logger methods to improve logging capabilities and maintainability.
- Added GeneratorOptions type to the GeneratorExecutionCommand for improved type safety. - Simplified parameter destructuring in baseGenerator by removing unused properties. - Updated frameworkPreviewParts handling in baseGenerator to utilize options directly.
- Streamlined the framework configuration in baseGenerator by removing unnecessary object wrapping around the framework name. - Improved readability and maintainability of the code by directly assigning the frameworkPackagePath.
- Deleted the ConfigGenerationService implementation and its test file to streamline the codebase. - This change eliminates unused code and focuses on maintaining only necessary components for configuration generation.
- Updated tests for AddonConfigurationCommand to include expectations for logger and prompt objects. - Enhanced test coverage by ensuring that these properties are correctly passed during the command execution.
- Updated various CLI command files to replace string-based feature handling with a new Feature enum for improved type safety and consistency. - Modified the copyTemplateFiles function to utilize Set<Feature> instead of string arrays for feature management. - Removed deprecated GeneratorFeature type and associated tests to streamline the codebase. - Enhanced overall maintainability and readability of the code by standardizing feature references.
- Added 'Feature' to the exported types in exports.ts for enhanced type safety. - Removed unused exports related to ConfigGenerationService in index.ts to streamline the codebase and improve maintainability.
- Replaced the DependencyCalculator with a new AddonService to manage Storybook addons more effectively. - Updated GeneratorExecutionCommand and baseGenerator to utilize the AddonService for addon configuration based on selected features. - Removed the DependencyCalculator and its associated tests to streamline the codebase. - Added tests for the new AddonService to ensure correct functionality and feature handling.
…unused CLI_COLORS import
…uage and improve version satisfaction checks in ProjectTypeService
This reverts commit 0abdc8c.
CLI: Modernize Storybook CLI with new init workflow, Clack UI, and Generator System
github-actions
bot
requested review from
jonniebigodes and
kylegach
as code owners
github-actions
bot
added
the
release
valentinpalkovic
added
ci:daily
|
View your CI Pipeline Execution ↗ for commit c1f2d63
☁️ Nx Cloud last updated this comment at |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 2 | 2 | 0 |
| Self size | 414 KB | 181 KB | 🎉 -232 KB 🎉 |
| Dependency size | 2.97 MB | 2.97 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
@storybook/addon-vitest
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 6 | 2 | 🎉 -4 🎉 |
| Self size | 441 KB | 375 KB | 🎉 -66 KB 🎉 |
| Dependency size | 570 KB | 338 KB | 🎉 -232 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/builder-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 11 | 17 | 🚨 +6 🚨 |
| Self size | 291 KB | 304 KB | 🚨 +13 KB 🚨 |
| Dependency size | 1.30 MB | 2.00 MB | 🚨 +701 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/builder-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 187 | 191 | 🚨 +4 🚨 |
| Self size | 66 KB | 75 KB | 🚨 +9 KB 🚨 |
| Dependency size | 31.98 MB | 32.19 MB | 🚨 +217 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 44 | 39 | 🎉 -5 🎉 |
| Self size | 21.70 MB | 19.20 MB | 🎉 -2.50 MB 🎉 |
| Dependency size | 17.16 MB | 16.40 MB | 🎉 -755 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/angular
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 187 | 191 | 🚨 +4 🚨 |
| Self size | 114 KB | 118 KB | 🚨 +3 KB 🚨 |
| Dependency size | 29.99 MB | 30.22 MB | 🚨 +225 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/ember
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 191 | 195 | 🚨 +4 🚨 |
| Self size | 15 KB | 15 KB | 🚨 +18 B 🚨 |
| Dependency size | 28.69 MB | 28.91 MB | 🚨 +225 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/html-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 14 | 20 | 🚨 +6 🚨 |
| Self size | 22 KB | 22 KB | 0 B |
| Dependency size | 1.63 MB | 2.34 MB | 🚨 +715 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/nextjs
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 533 | 537 | 🚨 +4 🚨 |
| Self size | 645 KB | 645 KB | 🎉 -110 B 🎉 |
| Dependency size | 58.90 MB | 59.13 MB | 🚨 +227 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/nextjs-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 124 | 128 | 🚨 +4 🚨 |
| Self size | 1.12 MB | 1.12 MB | 🎉 -224 B 🎉 |
| Dependency size | 21.72 MB | 21.95 MB | 🚨 +231 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/preact-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 14 | 20 | 🚨 +6 🚨 |
| Self size | 13 KB | 13 KB | 0 B |
| Dependency size | 1.61 MB | 2.33 MB | 🚨 +715 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-native-web-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 156 | 160 | 🚨 +4 🚨 |
| Self size | 30 KB | 30 KB | 🎉 -18 B 🎉 |
| Dependency size | 22.90 MB | 23.13 MB | 🚨 +231 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 114 | 118 | 🚨 +4 🚨 |
| Self size | 35 KB | 35 KB | 🚨 +130 B 🚨 |
| Dependency size | 19.52 MB | 19.75 MB | 🚨 +231 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 273 | 277 | 🚨 +4 🚨 |
| Self size | 24 KB | 24 KB | 🎉 -12 B 🎉 |
| Dependency size | 43.85 MB | 44.08 MB | 🚨 +227 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/server-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 199 | 203 | 🚨 +4 🚨 |
| Self size | 16 KB | 16 KB | 🚨 +12 B 🚨 |
| Dependency size | 33.22 MB | 33.45 MB | 🚨 +226 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/svelte-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 19 | 24 | 🚨 +5 🚨 |
| Self size | 56 KB | 56 KB | 🎉 -12 B 🎉 |
| Dependency size | 26.75 MB | 27.00 MB | 🚨 +255 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/sveltekit
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 20 | 25 | 🚨 +5 🚨 |
| Self size | 56 KB | 56 KB | 0 B |
| Dependency size | 26.80 MB | 27.06 MB | 🚨 +255 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/vue3-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 109 | 114 | 🚨 +5 🚨 |
| Self size | 36 KB | 35 KB | 🎉 -176 B 🎉 |
| Dependency size | 43.90 MB | 44.15 MB | 🚨 +255 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/web-components-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 15 | 21 | 🚨 +6 🚨 |
| Self size | 19 KB | 19 KB | 0 B |
| Dependency size | 1.65 MB | 2.37 MB | 🚨 +715 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 188 | 173 | 🎉 -15 🎉 |
| Self size | 838 KB | 770 KB | 🎉 -68 KB 🎉 |
| Dependency size | 71.37 MB | 66.17 MB | 🎉 -5.21 MB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 170 | 166 | 🎉 -4 🎉 |
| Self size | 30 KB | 30 KB | 🎉 -25 B 🎉 |
| Dependency size | 67.91 MB | 64.74 MB | 🎉 -3.17 MB 🎉 |
| Bundle Size Analyzer | Link | Link |
create-storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 45 | 40 | 🎉 -5 🎉 |
| Self size | 1.45 MB | 998 KB | 🎉 -454 KB 🎉 |
| Dependency size | 38.86 MB | 35.60 MB | 🎉 -3.25 MB 🎉 |
| Bundle Size Analyzer | node | node |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
10.1.0-alpha.12to10.1.0-alpha.13.Once this pull request is merged, it will trigger a new release of version
10.1.0-alpha.13.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
10.1.0-alpha.13