-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
TypeScript: Support exactOptionalPropertyTypes for public API types
#33149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
|
Also credit the author of commit 9b58ef1 on PR 27202 |
|
View your CI Pipeline Execution ↗ for commit afd501d
☁️ Nx Cloud last updated this comment at |
exactOptionalPropertyTypes for public API types
exactOptionalPropertyTypes for public API typesexactOptionalPropertyTypes for public API types
Co-authored-by: Sidnioulz <[email protected]>
Co-authored-by: Sidnioulz <[email protected]>
1dbb8e2 to
b7549fe
Compare
📝 WalkthroughWalkthroughWidened several optional string properties across TypeScript definitions to explicitly allow Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
✨ Finishing touches
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
Comment |
Closes #27129
What I did
Users with
exactOptionalPropertyTypes: truecould not passundefinedto optional type properties likeargTypes.table.type.summarydue to TypeScript's strict interpretation ofprop?: string(allows omission only, not explicitundefined).Updated public API type definitions to explicitly allow
undefined:PropSummaryValue(PropDef.ts, ArgsTable/types.ts):summary?: string→summary?: string | undefinedInputType.table(story.ts, ArgsTable/types.ts): Added| undefinedtotype.summary,type.detail,defaultValue.summary,defaultValue.detailComponentManifest(core-common.ts): Added| undefinedtodescription,import,summary,snippetfieldsUsers can now suppress automatic summary generation:
Changes are backward compatible—users without
exactOptionalPropertyTypesare unaffected.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Not required—changes are type-only. Verified with TypeScript compiler that:
undefinedwithexactOptionalPropertyTypes: trueDocumentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>Original prompt
summary: undefinedtype issue #27129💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.