-
-
Notifications
You must be signed in to change notification settings - Fork 10k
Build: Try out NX agents #33150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Try out NX agents #33150
Changes from 1 commit
c65a783
45e6f41
b96d8b6
4815dd0
0812f33
5889731
1644680
9c09531
36db0b3
2f45799
c10cca9
11da1a4
4694e9d
908eefb
c9f56bf
4622396
a8c6d41
1b72107
3d7f007
5caad09
b68e98e
8b63ec2
ffc7857
0f2c997
c2e3773
b1ba7b2
32bb4b0
40f2c1d
3cd7a0f
bf2a3d9
2483221
82f6baf
0779ef3
4916d39
bf04639
a102952
035dfa3
1d8048b
d370e3b
975b14f
a706f5f
4703f2a
3b25ae5
497caa6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "snapshot": "snapshot-20250521-0222c8bd-0a11-48ab-a2a8-380203843e05", | ||
| "install": "cd /workspace/scripts && yarn && cd ../code && yarn && yarn task --task=compile --start-from=compile", | ||
| "install": "yarn && yarn task --task=compile --start-from=compile", | ||
| "start": "cd /workspace/code && yarn test", | ||
| "terminals": [] | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ on: | |
| push: | ||
| branches: | ||
| - next | ||
| - kasper/nx-agents | ||
|
Comment on lines
+7
to
+8
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove TODO comments and temporary test branch before merging. Lines 7–8 and 52–55 reference the Apply this diff to clean up: on:
push:
branches:
- next
- # TODO remove
- - kasper/nx-agents
pull_request:
types: [opened, synchronize, labeled, reopened] - if: github.event_name == 'push' &&
github.ref == 'refs/heads/next'
run: yarn nx run-many -t $ALL_TASKS -c production -p="tag:ci:normal,tag:ci:merged"
- # TODO remove
- - if: github.event_name == 'push' &&
- github.ref == 'refs/heads/kasper/nx-agents'
- run: yarn nx run-many -t $ALL_TASKS -c production -p="tag:ci:normal"Also applies to: 52-55 🤖 Prompt for AI Agents |
||
| pull_request: | ||
| types: [opened, synchronize, labeled, reopened] | ||
|
|
||
|
|
@@ -18,13 +19,13 @@ jobs: | |
| nx: | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| ALL_TASKS: check,knip,test,pretty-docs,lint,test,sandbox,build-sandbox,e2e-tests,e2e-tests-dev,test-runner,vitest-integration,check-sandbox,e2e-ui,jest,vitest,playwright-ct,cypress | ||
| ALL_TASKS: check,knip,test,pretty-docs,lint,sandbox,build-sandbox,e2e-tests,e2e-tests-dev,test-runner,vitest-integration,check-sandbox,e2e-ui,jest,vitest,playwright-ct,cypress | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| filter: tree:0 | ||
| fetch-depth: 0 | ||
| - run: npx nx@latest start-ci-run --distribute-on=" ./.nx/workflows/distribution-config.yaml" --stop-agents-after="$ALL_TASKS" | ||
| - run: npx nx@latest start-ci-run --distribute-on="./.nx/workflows/distribution-config.yaml" --stop-agents-after="$ALL_TASKS" | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 22 | ||
|
|
@@ -36,4 +37,4 @@ jobs: | |
| - if: github.event_name == 'pull_request' && (contains(github.event.pull_request.labels.*.name, 'ci:merged')) | ||
| run: yarn nx run-many -t $ALL_TASKS -c production -p="tag:ci:normal,tag:ci:merged" | ||
| - if: github.event_name == 'push' || contains(github.event.pull_request.labels.*.name, 'ci:daily') | ||
| run: yarn nx run-many -t $ALL_TASKS -c production -p="tag:ci:normal,tag:ci:merged,tag:ci:daily" | ||
| run: yarn nx run-many -t $ALL_TASKS -c production -p="tag:ci:normal,tag:ci:merged,tag:ci:daily" | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,7 +26,7 @@ export async function getCodeWorkspaces(includePrivate = true) { | |
| return { | ||
| name: it.name, | ||
| // strip code from the location for backwards compatibility | ||
| location: it.location.replace('code/', '').replace('code', '.'), | ||
| location: it.location === 'code' ? '.' : it.location.replace('code/', ''), | ||
| }; | ||
| }) as Workspace[]; | ||
| } | ||
|
Comment on lines
+9
to
30
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chainPossible Windows path issue when stripping the leading The new location: it.location
.split(path.sep)
.filter((it, i) => !(it === 'code' && i === 0))
.join(path.sep),assumes Yarn’s
To keep semantics consistent across platforms, consider normalizing or splitting on both separators: - location: it.location
- .split(path.sep)
+ location: it.location
+ .split(/[\\/]/)
.filter((segment, i) => !(segment === 'code' && i === 0))
- .join(path.sep),
+ .join(path.sep),You could also avoid the Please verify on a Windows environment (or CI job) that:
Also applies to: 37-45 🏁 Script executed: #!/bin/bash
# Locate and inspect the getCodeWorkspaces function
fd workspace.ts --type f | head -20Length of output: 107 🏁 Script executed: #!/bin/bash
# Search for getCodeWorkspaces usage across the codebase
rg -n "getCodeWorkspaces" --type ts --type js -C 3Length of output: 4428 🏁 Script executed: #!/bin/bash
# Inspect lines 37-45 of workspace.ts to see the "also applies to" section
cat scripts/utils/workspace.ts | head -50 | tail -20Length of output: 650 🏁 Script executed: #!/bin/bash
# Search for how workspace.location is used in callers
rg -n "workspace\.location" --type ts --type js -C 2Length of output: 235 🏁 Script executed: #!/bin/bash
# Check if any path normalization utilities exist in the codebase
rg -n "normalize|sep|split.*\/" --type ts --type js scripts/ | grep -i path | head -20Length of output: 110 🏁 Script executed: #!/bin/bash
# Search for workspacePath usage
rg -n "workspacePath" --type ts --type js -C 2Length of output: 2764 🏁 Script executed: #!/bin/bash
# View the complete workspace.ts file to understand context
cat scripts/utils/workspace.tsLength of output: 1495 🏁 Script executed: #!/bin/bash
# Search for CODE_DIRECTORY and how it's used with workspace paths
rg -n "CODE_DIRECTORY" --type ts --type js -C 2 | head -50Length of output: 2891 🏁 Script executed: #!/bin/bash
# Check what Yarn outputs - look at any comments or docs referencing path format
rg -n "yarn.*workspaces|workspaces.*list" --type ts --type js -iLength of output: 499 🌐 Web query: 💡 Result: Short answer: Yes — Yarn's workspaces list (JSON/verbose output) uses forward slashes (POSIX-style) for workspace locations even on Windows. [1][2] Sources:
Windows path stripping fails because Yarn outputs forward slashes on all platforms The implementation splits
This breaks callers like Fix: Split on both forward and back slashes: - location: it.location
- .split(path.sep)
+ location: it.location
+ .split(/[\/\\]/)
.filter((segment, i) => !(segment === 'code' && i === 0))
- .join(path.sep),
+ .join(path.sep),Also applies to line 37 (
🤖 Prompt for AI Agents |
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.