-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
CLI: Update clack #33151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
CLI: Update clack #33151
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0e5f1c5
CLI: Update clack
valentinpalkovic 33ca730
CLI: Change task message from stop to cancel for project detection
valentinpalkovic 9524438
CLI: Change spinner message from stop to error and update success mes…
valentinpalkovic 9876f85
Revert
valentinpalkovic e02f7e6
CLI: Use spinner.stop for success and reserve spinner.cancel for abor…
valentinpalkovic 7a40d76
Remove Agents.md
valentinpalkovic 392b378
CLI: Add stop method to spinner instance and update task execution to…
valentinpalkovic 1e80e8d
Refactor logger imports in spinner and taskLog functions
valentinpalkovic 8e7a331
CLI: Update task and spinner methods to use stop for project detectio…
valentinpalkovic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| # Repository Guidelines | ||
|
|
||
| ## Project Structure & Module Organization | ||
| - Root packages live under `code/*` (e.g., `code/core`, `code/lib/create-storybook`, `code/frameworks`). Each package uses `src/` for code with colocated tests. | ||
| - Scripts and dev tooling: `scripts/` (sandbox generation, tasks, CI helpers). | ||
| - Example sandboxes: `sandbox/`; documentation: `docs/`. | ||
|
|
||
| ## Build, Test, and Development Commands | ||
| - `yarn i` — bootstrap the repo (installs and builds scripts, then packages). | ||
| - `yarn task --task dev --template react-vite/default-ts` — run a local sandbox dev workflow. | ||
| - `yarn --cwd code build` — build all packages. | ||
| - `yarn test` (root) or `yarn --cwd code test` — run Vitest across packages. | ||
| - Important: after changes that affect sandboxes or compiled outputs, run `yarn task --task "compile"` before validating with Vitest. | ||
|
|
||
| ## Coding Style & Naming Conventions | ||
| - TypeScript-first. Use top‑level `import` statements; avoid `require`. | ||
| - Formatting via Prettier; lint with ESLint: `yarn --cwd code lint`. | ||
| - Naming: descriptive; files use kebab-case; types/classes use PascalCase. | ||
|
|
||
| ## Testing Guidelines | ||
| - Framework: Vitest (repository-wide). Aim to maintain or improve coverage where you touch code. Use snapshots intentionally. | ||
|
|
||
| ### Use Wallaby.js first | ||
| - Use Wallaby.js for test results, errors, and debugging | ||
| - Leverage runtime values and coverage data when debugging tests | ||
| - Fall back to terminal only if Wallaby isn't available | ||
|
|
||
| 1. Analyze failing tests with Wallaby and identify the cause of the failure. | ||
| 2. Use Wallaby's covered files to find relevant implementation files or narrow your search. | ||
| 3. Use Wallaby's runtime values tool and coverage tool to support your reasoning. | ||
| 4. Suggest and explain a code fix that will resolve the failure. | ||
| 5. After the fix, use Wallaby's reported test state to confirm that the test now passes. | ||
| 6. If the test still fails, continue iterating with updated Wallaby data until it passes. | ||
| 7. If a snapshot update is needed, use Wallaby's snapshot tools for it. | ||
|
|
||
| When responding: | ||
| - Explain your reasoning step by step. | ||
| - Use runtime and coverage data directly to justify your conclusions. | ||
|
|
||
| ## Commit & Pull Request Guidelines | ||
| - Commits: concise, imperative subject lines; reference issues when applicable. | ||
| - PRs: include a clear description, rationale, and testing notes (what you ran, e.g., `yarn --cwd code test`). Add screenshots/logs when relevant and link related issues/PRs. | ||
|
|
||
| ## Security & Configuration Tips | ||
| - Do not commit secrets. Use environment variables and local `.env` files. | ||
| - Keep local tool versions aligned (see `.nvmrc` and `packageManager`). Update docs when changing commands or flags. | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.