Skip to content

Core: Minor UI fixes #33218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valentinpalkovic merged 2 commits into from
Nov 29, 2025
Merged

Core: Minor UI fixes #33218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d12eaa
Add missing ariaLabel props
ghengeveld Nov 28, 2025
0461680
Prevent ugly default outline from showing up on tooltips and popovers…
ghengeveld Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions code/core/src/components/components/Popover/PopoverProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,7 @@ export const PopoverProvider = ({
{...props}
>
<Pressable>{children}</Pressable>
<PopoverUpstream
placement={placement}
offset={offset}
style={{ outlineColor: 'transparent' }}
>
<PopoverUpstream placement={placement} offset={offset} style={{ outline: 'none' }}>
<Popover
hasChrome={hasChrome}
hideLabel={closeLabel}
Expand Down
2 changes: 1 addition & 1 deletion code/core/src/components/components/tooltip/TooltipProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ const TooltipProvider = ({
placement={placement}
offset={offset}
onOpenChange={onOpenChange}
style={{ outlineColor: 'transparent' }}
style={{ outline: 'none' }}
{...props}
>
{tooltip}
Expand Down
3 changes: 2 additions & 1 deletion code/core/src/manager/components/sidebar/TagsFilterPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ export const TagsFilterPanel = ({
id: `filter-${type}-${id}`,
content: (
<ActionList.HoverItem targetId={`filter-${type}-${id}`}>
<ActionList.Action as="label" tabIndex={-1} tooltip={toggleTooltip}>
<ActionList.Action as="label" ariaLabel={false} tabIndex={-1} tooltip={toggleTooltip}>
<ActionList.Icon>
{isExcluded ? <DeleteIcon /> : isIncluded ? null : icon}
<Form.Checkbox
Expand Down Expand Up @@ -201,6 +201,7 @@ export const TagsFilterPanel = ({
<ActionList as="div">
<ActionList.Item as="div">
<ActionList.Link
ariaLabel={false}
href={api.getDocsUrl({ subpath: 'writing-stories/tags#custom-tags' })}
target="_blank"
>
Expand Down