Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -255,10 +255,6 @@ jobs:
- run:
command: |
yarn
yarn task --task compile --start-from=auto --no-link --debug
name: Compile
- run:
command: |
yarn task --task check --start-from=auto --no-link --debug
name: Check
- run:
Expand Down
6 changes: 1 addition & 5 deletions .circleci/src/jobs/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,10 @@ steps:
name: Restore Yarn cache
keys:
- build-yarn-2-cache-v5--{{ checksum "yarn.lock" }}
- run:
name: Compile
command: |
yarn
yarn task --task compile --start-from=auto --no-link --debug
- run:
name: Check
command: |
yarn
yarn task --task check --start-from=auto --no-link --debug
- run:
name: Ensure no changes pending
Expand Down
2 changes: 1 addition & 1 deletion code/addons/a11y/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/addons/a11y"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/addons/docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/addons/docs"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/addons/links/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/addons/links"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/addons/onboarding/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/addons/onboarding"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/addons/pseudo-states/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/addons/pseudo-states"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/addons/themes/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/addons/themes"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/addons/vitest/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/addons/vitest"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/builders/builder-vite/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/builders/builder-vite"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/builders/builder-webpack5/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/builders/builder-webpack5"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/core"
},
"funding": {
Expand Down
6 changes: 5 additions & 1 deletion code/core/src/bin/dispatcher.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,13 @@ async function run() {
// the package couldn't be imported, use npx to install and run it instead
}

const { default: packageJson } = await import(`storybook/package.json`, {
with: { type: 'json' },
});

const child = executeCommand({
command: 'npx',
args: ['--yes', `${targetCli.pkg}@${versions[targetCli.pkg]}`, ...targetCli.args],
args: ['--yes', `${targetCli.pkg}@${packageJson.version}`, ...targetCli.args],
stdio: 'inherit',
});
child.on('exit', (code) => {
Expand Down
7 changes: 6 additions & 1 deletion code/core/src/common/js-package-manager/JsPackageManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,10 @@ export abstract class JsPackageManager {

const isLatestStableRelease = currentVersion === latestInRange;

if (latestInRange?.includes('-local.')) {
return `${packageName}@local`;
}
Comment on lines +383 to +385
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

# First, find the file and get context around the mentioned lines
fd -t f "JsPackageManager.ts" code/

Repository: storybookjs/storybook

Length of output: 124


🏁 Script executed:

# Read the file to understand the context
wc -l code/core/src/common/js-package-manager/JsPackageManager.ts

Repository: storybookjs/storybook

Length of output: 128


🏁 Script executed:

# Get the specific sections mentioned in the review
sed -n '375,395p' code/core/src/common/js-package-manager/JsPackageManager.ts

Repository: storybookjs/storybook

Length of output: 653


🏁 Script executed:

# Get lines 448-449
sed -n '440,455p' code/core/src/common/js-package-manager/JsPackageManager.ts

Repository: storybookjs/storybook

Length of output: 570


🏁 Script executed:

# Find the getVersionedPackages function
ast-grep --pattern 'getVersionedPackages($$$) {
  $$$
}'

Repository: storybookjs/storybook

Length of output: 47


🏁 Script executed:

# Find the getVersion function
ast-grep --pattern 'getVersion($$$) {
  $$$
}'

Repository: storybookjs/storybook

Length of output: 47


🏁 Script executed:

# Find all calls to getVersion and getVersionedPackages
rg "getVersion\(|getVersionedPackages\(" code/ --type ts --type tsx

Repository: storybookjs/storybook

Length of output: 92


🏁 Script executed:

# Fix rg search - use correct flags
rg "getVersion\(|getVersionedPackages\(" code --type ts

Repository: storybookjs/storybook

Length of output: 2067


🏁 Script executed:

# Let me get the full function context for getVersionedPackages starting around line 375
sed -n '350,400p' code/core/src/common/js-package-manager/JsPackageManager.ts

Repository: storybookjs/storybook

Length of output: 1822


🏁 Script executed:

# Get the full getVersion function context around 448
sed -n '425,460p' code/core/src/common/js-package-manager/JsPackageManager.ts

Repository: storybookjs/storybook

Length of output: 1289


🏁 Script executed:

# Find function definitions
grep -n "getVersion\|getVersionedPackages" code/core/src/common/js-package-manager/JsPackageManager.ts | head -20

Repository: storybookjs/storybook

Length of output: 422


🏁 Script executed:

# Look at the actual callers more closely
sed -n '1,20p' code/lib/create-storybook/src/generators/REACT_NATIVE/index.ts

Repository: storybookjs/storybook

Length of output: 905


🏁 Script executed:

# Find the context where getVersionedPackages is called in baseGenerator
grep -n "getVersionedPackages" code/lib/create-storybook/src/generators/baseGenerator.ts

Repository: storybookjs/storybook

Length of output: 139


🏁 Script executed:

# See how the result is used after getVersionedPackages call
sed -n '70,120p' code/lib/create-storybook/src/generators/baseGenerator.ts

Repository: storybookjs/storybook

Length of output: 1687


🏁 Script executed:

# Look at test file to see how 'local' is tested
cat -n code/core/src/common/js-package-manager/JsPackageManager.test.ts | grep -A10 -B5 "local"

Repository: storybookjs/storybook

Length of output: 47


🏁 Script executed:

# Check how the results from getVersionedPackages are used - see what happens with the version strings
rg "getVersionedPackages" code/lib/create-storybook/src/generators/baseGenerator.ts -A 10

Repository: storybookjs/storybook

Length of output: 478


🏁 Script executed:

# Check the CLI helpers to see how getVersion is used
sed -n '1,100p' code/core/src/cli/helpers.ts | grep -A5 -B5 "getVersion"

Repository: storybookjs/storybook

Length of output: 817


🏁 Script executed:

# Check test file more thoroughly for null scenarios
cat code/core/src/common/js-package-manager/JsPackageManager.test.ts | grep -n "null\|undefined\|local" -i

Repository: storybookjs/storybook

Length of output: 47


🏁 Script executed:

# Look at latestVersion implementation to understand when it returns null
sed -n '475,550p' code/core/src/common/js-package-manager/JsPackageManager.ts

Repository: storybookjs/storybook

Length of output: 2854


🏁 Script executed:

# Check if there are any guards in callers of getVersionedPackages
grep -B5 -A15 "getVersionedPackages" code/lib/create-storybook/src/generators/baseGenerator.ts | head -40

Repository: storybookjs/storybook

Length of output: 759


🏁 Script executed:

# See the full context of line 388 in getVersionedPackages
sed -n '375,395p' code/core/src/common/js-package-manager/JsPackageManager.ts

Repository: storybookjs/storybook

Length of output: 653


🏁 Script executed:

# Check how dependencyCollector.addDevDependencies handles the version specs
fd -t f "dependencyCollector\|DependencyCollector" code/ --type ts | head -5

Repository: storybookjs/storybook

Length of output: 234


🏁 Script executed:

# Let me verify what happens when @^null would be passed to npm/yarn
# Check if there are any tests that explicitly test error scenarios
grep -n "null\|error\|Error" code/core/src/common/js-package-manager/JsPackageManager.test.ts | head -20

Repository: storybookjs/storybook

Length of output: 200


🏁 Script executed:

# See if there are mock/stub tests that return null from latestVersion
grep -n "latestVersion\|Mock\|mock" code/core/src/common/js-package-manager/JsPackageManager.test.ts | head -30

Repository: storybookjs/storybook

Length of output: 571


🏁 Script executed:

# Check npm/yarn spec parsing to confirm @local is valid
rg "@local|dist-tag" code --type ts -i | head -10

Repository: storybookjs/storybook

Length of output: 165


🏁 Script executed:

# Final verification: check if there are any error handling tests or scenarios
sed -n '1,100p' code/core/src/common/js-package-manager/JsPackageManager.test.ts

Repository: storybookjs/storybook

Length of output: 1777


Add null-guard for latestInRange in getVersionedPackages to prevent invalid package specs

In getVersionedPackages, if latestVersion() returns null (due to network errors or registry issues) and the version doesn't contain -local., line 388 will produce an invalid spec like @^null. Although getVersion() guards against this with an explicit null check, getVersionedPackages() lacks protection.

Add a simple null check after the -local. guard:

if (latestInRange?.includes('-local.')) {
  return `${packageName}@local`;
}

+if (!latestInRange) {
+  return currentVersion ? `${packageName}@${currentVersion}` : packageName;
+}
+
if (isLatestStableRelease || !currentVersion) {
  return `${packageName}@^${latestInRange}`;
}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
if (latestInRange?.includes('-local.')) {
return `${packageName}@local`;
}
if (latestInRange?.includes('-local.')) {
return `${packageName}@local`;
}
if (!latestInRange) {
return currentVersion ? `${packageName}@${currentVersion}` : packageName;
}
if (isLatestStableRelease || !currentVersion) {
return `${packageName}@^${latestInRange}`;
}
🤖 Prompt for AI Agents
In code/core/src/common/js-package-manager/JsPackageManager.ts around lines
383-385, the code assumes latestInRange is non-null which can produce invalid
specs like "@^null"; add a null-guard immediately after the existing '-local.'
check so that if latestInRange is null you skip versioning for that package
(e.g., continue the loop or push the bare packageName) instead of constructing a
spec using "null".


if (isLatestStableRelease || !currentVersion) {
return `${packageName}@^${latestInRange}`;
}
Expand Down Expand Up @@ -440,7 +444,8 @@ export abstract class JsPackageManager {
current && (!constraint || satisfies(current, constraint)) && gt(current, latest)
? current
: latest;
return `^${versionToUse}`;

return latest.includes('-local.') ? 'local' : `^${versionToUse}`;
}

/**
Expand Down
1 change: 1 addition & 0 deletions code/core/src/common/js-package-manager/NPMProxy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@ export class NPMProxy extends JsPackageManager {
const process = executeCommand({
command: 'npm',
args: ['info', packageName, ...args],
cwd: this.cwd,
});
const result = await process;
const commandResult = result.stdout ?? '';
Expand Down
1 change: 1 addition & 0 deletions code/core/src/common/js-package-manager/PNPMProxy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ export class PNPMProxy extends JsPackageManager {
const process = executeCommand({
command: 'pnpm',
args: ['info', packageName, ...args],
cwd: this.cwd,
});
const result = await process;
const commandResult = result.stdout ?? '';
Expand Down
1 change: 1 addition & 0 deletions code/core/src/common/js-package-manager/Yarn1Proxy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ export class Yarn1Proxy extends JsPackageManager {
const process = executeCommand({
command: 'yarn',
args: ['info', packageName, ...args],
cwd: this.cwd,
});
const result = await process;
const commandResult = result.stdout ?? '';
Expand Down
1 change: 1 addition & 0 deletions code/core/src/common/js-package-manager/Yarn2Proxy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,7 @@ export class Yarn2Proxy extends JsPackageManager {
const process = executeCommand({
command: 'yarn',
args: ['npm', 'info', packageName, ...args],
cwd: this.cwd,
});
const result = await process;
const commandResult = result.stdout ?? '';
Expand Down
2 changes: 1 addition & 1 deletion code/frameworks/angular/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/frameworks/angular"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/frameworks/ember/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/frameworks/ember"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/frameworks/html-vite/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/frameworks/html-vite"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/frameworks/nextjs-vite/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/frameworks/nextjs"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/frameworks/nextjs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/frameworks/nextjs"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/frameworks/preact-vite/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/frameworks/preact-vite"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/frameworks/react-native-web-vite/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/frameworks/react-native-web-vite"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/frameworks/react-vite/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/frameworks/react-vite"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/frameworks/react-webpack5/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/frameworks/react-webpack5"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/frameworks/server-webpack5/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/frameworks/server-webpack5"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/frameworks/svelte-vite/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/frameworks/svelte-vite"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/frameworks/sveltekit/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/frameworks/sveltekit"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/frameworks/vue3-vite/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/frameworks/vue3-vite"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/frameworks/web-components-vite/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/frameworks/web-components-vite"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/lib/cli-sb/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/lib/cli-sb"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/lib/cli-storybook/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/lib/cli-storybook"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/lib/codemod/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/lib/codemod"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/lib/core-webpack/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/lib/core-webpack"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/lib/create-storybook/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/lib/cli"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/lib/csf-plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/lib/csf-plugin"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/lib/eslint-plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/lib/eslint-plugin"
},
"license": "MIT",
Expand Down
2 changes: 1 addition & 1 deletion code/lib/react-dom-shim/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/lib/react-dom-shim"
},
"funding": {
Expand Down
2 changes: 1 addition & 1 deletion code/presets/create-react-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"repository": {
"type": "git",
"url": "https://github.com/storybookjs/storybook.git",
"url": "git+https://github.com/storybookjs/storybook.git",
"directory": "code/presets/create-react-app"
},
"funding": {
Expand Down
Loading