Skip to content

Conversation

@yannbf
Copy link
Member

@yannbf yannbf commented Dec 1, 2025

This reverts commit 7bf53d5.

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Chores
    • Updated internal GitHub Actions workflow configuration for sandbox generation, removing hard-coded branch references and implementing flexible branch checkout references.

✏️ Tip: You can customize this high-level summary in your review settings.

This reverts commit 7bf53d5.
@yannbf yannbf self-assigned this Dec 1, 2025
@yannbf yannbf added build Internal-facing build tooling & test updates ci:docs Run the CI jobs for documentation checks only. labels Dec 1, 2025
@yannbf yannbf merged commit 1f0efb8 into next Dec 1, 2025
11 of 12 checks passed
@yannbf yannbf deleted the yann/revert-sandbox-commit branch December 1, 2025 06:31
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 1, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Removed a hardcoded push trigger for a feature branch and updated checkout refs in the GitHub Actions workflow: generate-next now checks out next and generate-main now checks out main. The original push branch is commented out as a placeholder.

Changes

Cohort / File(s) Summary
Workflow configuration
\.github/workflows/generate-sandboxes\.yml
Replaced hardcoded push trigger referencing yann/fix-sandbox-generation-2 with a commented placeholder; changed actions/checkout ref in generate-next job to next and in generate-main job to main.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Check the commented trigger placeholder for intended use and clarity.
  • Confirm the updated checkout refs align with branch protection and CI expectations.

Possibly related PRs


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c6ff2fb and 7a02bfa.

📒 Files selected for processing (1)
  • .github/workflows/generate-sandboxes.yml (3 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Dec 1, 2025

View your CI Pipeline Execution ↗ for commit 7a02bfa

Command Status Duration Result
nx run-many -t compile --parallel=3 ✅ Succeeded 56s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-01 06:50:04 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:docs Run the CI jobs for documentation checks only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants