Nextjs-Vite: Install vite during migration if not installed yet
#33318
+45
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
- Add getDependencyVersion mock to package manager in tests - Split test into two scenarios: with and without vite installed - Test that vite@^7.0.0 is added when vite is not installed - Test that vite is not added when already installed Co-authored-by: valentinpalkovic <[email protected]>
- Add VITE_DEFAULT_VERSION constant in both implementation and tests - Add comment explaining explicit mock setup in test for clarity - Update test to use constant instead of hardcoded version Co-authored-by: valentinpalkovic <[email protected]>
- Export constant from main file to maintain single source of truth - Import constant in test file instead of duplicating - Remove redundant mock setup that was already done in beforeEach Co-authored-by: valentinpalkovic <[email protected]>
Copilot
AI
changed the title
[WIP] Add vite installation during Nextjs-Vite migration
Nextjs-Vite: Install Dec 9, 2025
vite during migration if not installed yet
valentinpalkovic
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
Added automigration
nextjs-to-nextjs-vitethat installsvite@^7.0.0as a devDependency when migrating from@storybook/nextjsto@storybook/nextjs-viteif vite isn't already present. This prevents broken projects when migrating from webpack-based Next.js to the new Vite-based framework.Implementation details:
@storybook/nextjspresence via package managergetDependencyVersion('vite')checkVITE_DEFAULT_VERSIONconstant for version consistencyChecklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
No manual testing required. The automigration logic is fully covered by unit tests that verify both scenarios: when vite is already installed and when it needs to be added.
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.