-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
Core: Fix onboarding visual bugs, survey telemetry and modal dismissal #33326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
fd0ccae
Ensure body never scrolls out of the viewport
ghengeveld d26a688
Reset panel height so guided tour tooltip can render correctly
ghengeveld 77aee15
Tweak controls panel styling to fix overflow issue and design consist…
ghengeveld a232aec
Emit 'openSurvey' event type when opening the IntentSurvey
ghengeveld 4877857
Fix onboarding survey open state handling
ghengeveld 9d81a4b
Merge branch 'next' into fix-onboarding-survey
ndelangen 22f271f
Merge branch 'next' into fix-onboarding-survey
ghengeveld ef16fc8
Slight improvement on interdependencies
ghengeveld File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Tweak controls panel styling to fix overflow issue and design consist…
…ent with other panels
- Loading branch information
commit 77aee15e3d348718e5fd59f62df87f0e47b267dc
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.