Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
React: Use self-closing tag for code snippets
  • Loading branch information
valentinpalkovic committed Dec 12, 2025
commit a819b69d6e00a06a086088f8e7556afc1e8fb18f
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,21 @@ function withCSF4(body: string) {
`;
}

test('Synthesizes self-closing when no children', () => {
const input = dedent`
import type { Meta } from '@storybook/react';
import { Button } from '@design-system/button';

const meta: Meta<typeof Button> = {
component: Button,
};
export default meta;

export const NoChildren: Story = {};
`;
expect(generateExample(input)).toMatchInlineSnapshot(`"const NoChildren = () => <Button />;"`);
});

test('Default', () => {
const input = withCSF3(`
export const Default: Story = {};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -222,13 +222,15 @@ export function getCodeSnippet(
const name = t.jsxIdentifier(componentName);
const openingElAttrs = invalidSpread ? [...injectedAttrs, invalidSpread] : injectedAttrs;

const children = toJsxChildren(merged.children);
const selfClosing = children.length === 0;
const arrow = t.arrowFunctionExpression(
[],
t.jsxElement(
t.jsxOpeningElement(name, openingElAttrs, false),
t.jsxClosingElement(name),
toJsxChildren(merged.children),
false
t.jsxOpeningElement(name, openingElAttrs, selfClosing),
selfClosing ? null : t.jsxClosingElement(name),
children,
selfClosing
)
);

Expand Down
Loading