Skip to content

React - use babel presets/plugins based on CRA. #4836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igor-dv merged 18 commits into from
Nov 24, 2018
Merged

React - use babel presets/plugins based on CRA. #4836

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
159ab43
Change babel default preset in react app to use babel configuration l…
igor-dv Nov 23, 2018
fb6c71f
Fix options warning
igor-dv Nov 23, 2018
47a9aa3
Add dynamic import example
igor-dv Nov 23, 2018
36a0446
Support svgr
igor-dv Nov 23, 2018
bccb39d
Use "babel-plugin-dynamic-import-node" for tests
igor-dv Nov 23, 2018
9e29f89
Merge remote-tracking branch 'origin/next' into react/cra-integration…
igor-dv Nov 23, 2018
be70a9e
Fix some warnings + separate stories
igor-dv Nov 23, 2018
78bc9d7
Delete index.js
igor-dv Nov 23, 2018
4544359
Use CRA's fileTransformer to import svgs
igor-dv Nov 23, 2018
ef18eb0
Fallback to regular `react-scripts` in case it fails on a custom
igor-dv Nov 24, 2018
55946c4
Move svgr and dynamic-imports to cra setup
igor-dv Nov 24, 2018
842dcc7
Refactor fallback in CRA preset a bit
igor-dv Nov 24, 2018
8ac0ebc
Merge remote-tracking branch 'origin/next' into react/cra-integration…
igor-dv Nov 24, 2018
012bfa7
Use "fs" to check if the r-s/pkg.json exists
igor-dv Nov 24, 2018
328a1eb
Support CRA's new format of webpack.config
igor-dv Nov 24, 2018
a452c86
Move test + try to fix
igor-dv Nov 24, 2018
c8cf219
Bring back babel-preset-react-app
igor-dv Nov 24, 2018
c331ec8
Set docgen to the end
igor-dv Nov 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Support svgr
  • Loading branch information
@igor-dv
igor-dv committed Nov 23, 2018
commit 36a044649c73aa8b4c8c6a4fec9cac5f484584b4
2 changes: 2 additions & 0 deletions app/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,12 @@
"prepare": "node ../../scripts/prepare.js"
},
"dependencies": {
"@babel/plugin-transform-react-constant-elements": "^7.0.0",
"@babel/runtime": "^7.1.2",
"@emotion/styled": "^0.10.6",
"@storybook/core": "4.1.0-alpha.7",
"@storybook/node-logger": "4.1.0-alpha.7",
"@svgr/webpack": "^4.0.3",
"babel-plugin-named-asset-import": "^0.2.3",
"babel-plugin-react-docgen": "^2.0.0",
"babel-preset-react-app": "^6.1.0",
Expand Down
0 ...ink/src/stories/dynamic-import.stories.js → ...src/stories/cra-dynamic-import.stories.js
View file
Open in desktop
File renamed without changes.
5 changes: 5 additions & 0 deletions examples/cra-kitchen-sink/src/stories/cra-svgr.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import React from 'react';
import { storiesOf } from '@storybook/react';
import { ReactComponent as Logo } from '../logo.svg';

storiesOf('CRA', module).add('Svgr', () => <Logo />);
Loading