Skip to content

UI: Add viewMode parameter to control story nav UI #9090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shilman merged 7 commits into from
Jan 28, 2020
Merged

UI: Add viewMode parameter to control story nav UI #9090

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2db3faa
added viewmode parameter
atanasster Dec 7, 2019
cac8b47
remove logs
atanasster Dec 7, 2019
e2c3d1b
var name paramViewMode
atanasster Dec 7, 2019
615ce7f
Merge branch 'next' into pr/9090
shilman Jan 28, 2020
d8e13a0
Sidebar: Clean up viewMode handling and add tests
shilman Jan 28, 2020
5eaf233
Merge branch 'next' into pr/9090
shilman Jan 28, 2020
3e086ef
Document viewMode story parameter
shilman Jan 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
var name paramViewMode
  • Loading branch information
@atanasster
atanasster committed Dec 7, 2019
commit e2c3d1b71dff848326d3d65edff94c51667e02a6
6 changes: 3 additions & 3 deletions lib/ui/src/components/sidebar/SidebarStories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@ const refinedViewMode = (
isDocsOnly: boolean,
parameters: { viewMode?: string } = {}
) => {
const { viewMode: pViewMode } = parameters;
if (typeof pViewMode === 'string') {
return pViewMode;
const { viewMode: paramViewMode } = parameters;
if (typeof paramViewMode === 'string') {
return paramViewMode;
}
if (isDocsOnly) {
return 'docs';
Expand Down