Add splitpane repo #955
Closed
Add splitpane repo #955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There may be more required for this to really work. require.js does not seem entirely happy with the built module since it's failing to scan the deps, but if I ensure they're already loaded things work. Which is at least a good first step!
event needs to be a specified argument of the handlers
Provide a way of building a standalone/UMD JS file
<SplitPane orientation="horizontal">
<div></div>
<div></div>
</SplitPane>
is now
<SplitPane split="vertical">
<div></div>
<div></div>
</SplitPane>
Add PropType.string for defaultSize to allow "xx%"
…add-splitpane-repo # Conflicts: # .gitignore # .npmignore # .travis.yml # LICENSE # README.md # package.json
Member
Author
|
@aaronmcadam @benediktvaldez Can you review? |
shilman
requested changes
Apr 24, 2017
Member
shilman
left a comment
shilman
left a comment
There was a problem hiding this comment.
@ndelangen please provide manual testing instructions in how to test section of PR 😸
Member
Author
|
Closing this, as @usulpro suggested it's better to not maintain this fork, and use the original here: https://github.com/tomkp/react-split-pane |
ghost
mentioned this pull request
|
View your CI Pipeline Execution ↗ for commit e6b421a.
☁️ Nx Cloud last updated this comment at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
ADD the split-pane repo to this repo
How to test
run
npm run test