Fix/use story state #9590
Closed
Fix/use story state #9590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). |
Contributor
atanasster
reviewed
Jan 26, 2020
Member
atanasster
left a comment
atanasster
left a comment
There was a problem hiding this comment.
I would suggest we leave out the story hooks/ store state for now, since they didn't work for the 'knobs-2' and the whole implementation is a bit over the top. The story_store already had built-in mechanism for HMR and sharing story states between preview and manager and seems the right place to store story state.
We will still have the addon shared state and its a great addition - it will simplify communication in addons btw manager and preview and make those things way simpler.
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.