Skip to content

Fix for test-cra was breaking the build #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2017
Merged

Fix for test-cra was breaking the build #972

merged 2 commits into from
Apr 28, 2017

Conversation

@ndelangen
Copy link
Member

@ndelangen ndelangen commented Apr 28, 2017

Issue: -none-

What I did

FIX for test-cra which was breaking the build,
because it’s dependencies are not managed by lerna.

@ndelangen ndelangen self-assigned this Apr 28, 2017
@ndelangen ndelangen force-pushed the fix-examples-failingbuild branch 2 times, most recently from 034b1ee to cdb29d2 Compare April 28, 2017 11:27
@ndelangen ndelangen force-pushed the fix-examples-failingbuild branch from cdb29d2 to 205b0f8 Compare April 28, 2017 11:36
@codecov
Copy link

codecov bot commented Apr 28, 2017 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@57b7161). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #972   +/-   ##
=========================================
  Coverage          ?   26.88%           
=========================================
  Files             ?      192           
  Lines             ?     4375           
  Branches          ?      700           
=========================================
  Hits              ?     1176           
  Misses            ?     3199           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57b7161...8f36abf. Read the comment docs.

@ndelangen ndelangen merged commit b0313a1 into master Apr 28, 2017
@ndelangen ndelangen deleted the fix-examples-failingbuild branch April 28, 2017 11:50
@shilman shilman mentioned this pull request May 18, 2017
Merged
@ndelangen ndelangen changed the title FIX for test-cra was breaking the build Fix for test-cra was breaking the build May 27, 2017
@ndelangen ndelangen added cleanup Minor cleanup style change that won't show up in release changelog and removed bug labels May 27, 2017
@nx-cloud
Copy link

nx-cloud bot commented Apr 2, 2024 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 8f36abf.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 30s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-03 01:49:08 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ndelangen ndelangen

Labels

cleanup Minor cleanup style change that won't show up in release changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ndelangen