Skip to content

Conversation

@zjeraar
Copy link
Contributor

@zjeraar zjeraar commented May 3, 2017

Issue: -

Updated dead getstorybook.io links to storybooks.js.org

@codecov
Copy link

codecov bot commented May 3, 2017

Codecov Report

Merging #988 into master will decrease coverage by 14.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #988       +/-   ##
==========================================
- Coverage   26.72%   12.6%   -14.12%     
==========================================
  Files         192     192               
  Lines        4427    4427               
  Branches      707     707               
==========================================
- Hits         1183     558      -625     
  Misses       3244    3244               
- Partials        0     625      +625
Impacted Files Coverage Δ
...ckages/react-storybook/demo/src/stories/Welcome.js 0% <ø> (-37.5%) ⬇️
packages/addon-info/src/index.js 0% <0%> (-66.67%) ⬇️
...mments/src/manager/components/CommentItem/style.js 0% <0%> (-50%) ⬇️
...mments/src/manager/components/CommentForm/style.js 0% <0%> (-50%) ⬇️
packages/addon-graphql/src/preview.js 0% <0%> (-50%) ⬇️
packages/addon-actions/src/preview.js 0% <0%> (-50%) ⬇️
...toryshots/stories/required_with_context/Welcome.js 0% <0%> (-42.86%) ⬇️
...ackages/react-storybook/src/server/babel_config.js 0% <0%> (-41.18%) ⬇️
.../react-native-storybook/src/server/config/utils.js 0% <0%> (-40%) ⬇️
...s/addon-graphql/src/components/FullScreen/index.js 0% <0%> (-40%) ⬇️
... and 125 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62bf99a...b59db9c. Read the comment docs.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks so much @zjeraar !

@shilman shilman merged commit 3558f8f into storybookjs:master May 3, 2017
@shilman shilman added the misc label May 27, 2017
@ndelangen ndelangen added the cleanup Minor cleanup style change that won't show up in release changelog label May 27, 2017
@nx-cloud
Copy link

nx-cloud bot commented May 15, 2024

View your CI Pipeline Execution ↗ for commit b59db9c.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 16s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-17 20:32:22 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Minor cleanup style change that won't show up in release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants