Repository navigation
Add Korean support - #1106
Draft
arksky1 wants to merge 2 commits into
Draft
Add Korean support#1106arksky1 wants to merge 2 commits into
arksky1 wants to merge 2 commits into
Conversation
Integrate contributor-reviewed Korean display strings, language selection and persisted UI preferences, and the shared Nanum Gothic font input. Preserve English defaults, command identifiers, stored document values and user names. Validation performed: catalog placeholder/duplicate checks, source delimiter and identifier scan, git diff --check. Rust/cargo/rustfmt are unavailable: cargo tests, cargo xtask ci, builds and actual UI execution were not run. This is draft work; runtime verification remains outstanding.
Apply contributor-reviewed dynamic wording while preserving command IDs, user names, English behavior and numeric time calculations. Validation: catalog/call-path static audit and 23 catalog composition fixtures passed; regression tests added. Rust/cargo/rustfmt, builds and actual UI were not run because the toolchain is unavailable and installation is not authorized.
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Korean language support for ArtCraft.