Skip to content

Add Korean support - #1106

Draft
arksky1 wants to merge 2 commits into
storytold:mainfrom
arksky1:feat/korean-support
Draft

arksky1 wants to merge 2 commits into
storytold:mainfrom
arksky1:feat/korean-support

Conversation

@arksky1

@arksky1 arksky1 commented Oct 21, 2026

Copy link
Copy Markdown

Add Korean language support for ArtCraft.

Integrate contributor-reviewed Korean display strings, language selection and
persisted UI preferences, and the shared Nanum Gothic font input. Preserve
English defaults, command identifiers, stored document values and user names.

Validation performed: catalog placeholder/duplicate checks, source delimiter
and identifier scan, git diff --check. Rust/cargo/rustfmt are unavailable:
cargo tests, cargo xtask ci, builds and actual UI execution were not run.
This is draft work; runtime verification remains outstanding.
Apply contributor-reviewed dynamic wording while preserving command IDs, user names, English behavior and numeric time calculations.

Validation: catalog/call-path static audit and 23 catalog composition fixtures passed; regression tests added. Rust/cargo/rustfmt, builds and actual UI were not run because the toolchain is unavailable and installation is not authorized.
@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@aiongg aiongg added the missing feature The reference application has it and we do not, or only part of it label Nov 4, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing feature The reference application has it and we do not, or only part of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants