Repository navigation
PDF: pin craft-pdf and krilla to craft-libs main - #1253
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Update PDF dependency pins and features Cargo.toml, crates/pdf/Cargo.toml |
The craft-pdf and Krilla dependencies use the updated revision. craft-pdf enables write-simple-text, and the native-target Krilla dependency disables default features. |
Align dependency validation and tests xtask/src/pdf_deps.rs |
The pinned revision, expected feature sets, target validation, test metadata, and invalid-feature cases reflect the updated dependency configuration. |
Priority:
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Bug fix
Possibly related issues
- [Audit] RND-10: Many full-size RGBA buffers in flight in krilla's async deflate (Low) figcraft#1105: The pull request updates Krilla and reports image-buffer robustness changes related to the issue’s PDF export memory concerns.
Suggested reviewers: skylartaylor
Merge Risk: 
Minimal · up to fdc2d
-
The dependency revisions and native/WASM feature checks are aligned, with no established merge-blocking defect.
Security architecture risk: 
Low · up to fdc2d
-
The update retains existing dependency restrictions and native/WASM feature checks. No concrete expansion of input reachability or command authority was identified, but the new decoder safeguard and resolved dependency features could not be independently confirmed.
Retained concerns
No architecture-level concerns identified.Security review details
-
Security Blast Radius
- inferred — The configuration change reaches PDF writer builds on native and WASM targets. The inspected CLI relationship does not establish any additional attacker-facing entrypoint; upstream decoder exposure was not independently traced.
Trust Boundaries and Controls
- observed — The existing production dependency boundary remains enforced: traversal excludes dev-only edges and rejects hayro parser packages reachable through production or build dependencies. Existing CARGO/RUSTC environment selection and fixed subprocess arguments are unchanged, rather than newly granted authority.
-
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passedFull details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 1 files. (2 skipped: 2 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Moves
craft-pdfand the patchedkrillafrom craft-libsc3487320to9f75d3dc(craft-libs#254). The writer gains an input bound: krilla's image decoder refuses a PNG that decodes to more than 1 GiB and reserves its buffers fallibly, so an oversized image is a decode error instead of an unbounded allocation.craft-mediaand the other craft-libs crates keep their pins.Cargo.toml: both pins move together.craft-pdfenableswrite-simple-text, because craft-libs made krilla's text shaper opt-in and the text layer and handout page numbers calldraw_text.crates/pdf/Cargo.toml: the native-onlykrilladependency turns off default features, so native and WASM resolve the same feature set (raster-images,simple-text, plusrayonon native).xtask pdf-deps: the pinned rev and the expected features follow.Checks
cargo xtask ciatfdc2dcdaon Linux, with craft-fonts at43913056(the ref CI uses): all 8 steps passed, includingpdf-depsandwasm. 1,789 tests passed, 6 skipped.Summary by CodeRabbit