Repository navigation
Docs: Play From and the .potx/.ppsx content types are no longer listed as missing - #1327
Conversation
…d as missing The Animation Pane row in ui-parity.md said the pane cannot preview from the selected effect, but its button reads Play From and starts there (animpane_tests). gaps.md, file-format-parity.md and the parity checklist said .potx and .ppsx are saved with the .pptx content type, but deckcraft_pptx::export_as writes the template and slide-show content types, as a test in crates/pptx/tests/it/roundtrip.rs checks. The gaps.md entry now covers only the macro-enabled variants. The checklist row stays partial, and cargo xtask parity leaves the summary unchanged.
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Format support and content types docs/gaps.md, docs/file-format-parity.md, docs/parity-checklist.md |
The documentation describes format-specific content types for .pptx, .potx, and .ppsx. It identifies .pptm, .potm, and .ppsm as unrecognized. The .potx and .ppsx entries include test references. |
Animation Pane documentation
| Layer / File(s) | Summary |
|---|---|
Play From behavior docs/ui-parity.md |
The Animation Pane entry states that Play From starts playback at the selected effect. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Other
Possibly related PRs
- storytold/deckcraft#1108: Adds
.potxand.ppsxoutputs whose format-specific save behavior is described here. - storytold/deckcraft#983: Handles web opening and saving of PowerPoint files, including
.potxand.ppsx.
Suggested reviewers: echelon
Merge Risk: 
Minimal · up to a9caf
-
No actionable merge-blocking risk remains.
Architecture risk: 
Low · up to a9caf
-
The change affects 1 system.
Changed systems:
docsArchitecture concerns
No architecture-level concerns identified.Review details
-
Systems and components
- observed — docs (service) was modified; 4 changed files map to changed impact.
Before / after behavior
- observed — Modified behavior in docs/file-format-parity.md: The
.potxand.ppsxentries change their write descriptions from.pptxcontent to their respective template and slide-show content types. The.potxtest reference changes from none tocrates/pptx/tests/it/roundtrip.rs; the.ppsxtest reference is specified ascrates/ui-egui/src/opening.rs. - observed — Modified behavior in docs/gaps.md: The entry now identifies
.pptm,.potmand.ppsmas unrecognized, and says macro decks cannot be opened even for viewing. It replaces the claim that template, slide-show and macro variants are saved as plain.pptx, noting instead that.pptx,.potxand.ppsxopen and save with their own main content types. - observed — Modified behavior in docs/parity-checklist.md: The checklist now says
.potxand.ppsxvariants open and save with their own content types, replacing the statement that saves used the.pptxcontent type. The.pptmlimitation remains. - observed — Modified behavior in docs/ui-parity.md: The Animation Pane description adds that Play From starts at the selected effect and removes the prior statement that preview from the selected effect was unavailable.
-
Pre-merge checks: 
5
-
Full details: Title check
-
Explanation
The title names two of the changes in the PR, Play From and the .potx/.ppsx content types. Those are real parts of the changeset. The PR also updates gaps.md, file-format-parity.md, and parity-checklist.md, and the title does not mention the macro-enabled .pptm/.potm/.ppsm limitation. The title is partially related: it refers to real changes but is not fully comprehensive. Also, the title is accurate to the actual changes, as Play From is documented as present and the .potx/.ppsx content types are described correctly.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Usage-based review receipt
- Mode: Continue automatically
- Reviewed files: 4
- Waived: $1.00 (charged $0.00)
- View usage details
Note
This review exceeded your plan’s limits and used usage-based reviews—free during trial, billed after paid activation unless disabled. Manage usage-based reviews.
Comment @coderabbitai help to get the list of available commands.
Five parity rows and entries on
mainat38d2adedescribe features as missing thatmainalready has.docs/ui-parity.md, Animation Pane: the row said "no preview from the selected effect". With an effect selected the pane's button reads Play From and starts the preview at that effect (crates/ui-egui/src/panes.rs:1032,animpane_tests::play_from_starts_at_the_selected_effect).docs/animation-parity.mdanddocs/gaps.mdalready say so.docs/gaps.md,docs/file-format-parity.mdanddocs/parity-checklist.md: these said.potxand.ppsxare saved with the.pptxcontent type.deckcraft_pptx::export_aswrites the template and slide-show main content types (crates/pptx/src/lib.rs:82-90), andsave_bytesincrates/engine/src/cmd/file.rscalls it for both formats.roundtrip.rs::templates_and_slide_shows_declare_their_own_main_content_typechecks it.What changes:
gaps.mdentry covers only the macro-enabled.pptm/.potm/.ppsmfiles, which are still not read. Its estimate is unchanged..potxand.ppsxrows offile-format-parity.mdsay yes in the write column, and the.potxrow namescrates/pptx/tests/it/roundtrip.rsas its test..potx/.ppsxsave with their own content types. It stays partial for.pptm, andcargo xtask parityleaves the summary unchanged.Status lines and revision histories are unchanged.
Open #523 (
.pptm) rewrites the samegaps.mdentry, and open #304 (templates) rewrites that entry and the twofile-format-parity.mdrows, so each of them conflicts with this change in those lines. Open #711 rewrites the Animation Pane row from an older base and also conflicts with this change; it already conflicts withmainindocs/ui-parity.mdanddocs/gaps.md.Checks:
cargo xtask parity, which produced no change to the summary.On Windows 11 (x86-64) with rustc 1.99.1, on top of
mainat38d2ade, with #1292, #1298 and #1300 merged in:cargo xtask cipasses its 8 steps: 1,880 tests passed, 0 failed, 6 ignored.Without #1298,
control_server::tests::a_pipelined_peer_still_reads_why_its_line_was_rejectedfails intermittently onmainat38d2adetoo (upstream CI fails it on that commit); #1298 fixes it.git merge-treereports no conflicts withmainat38d2ade.Summary by CodeRabbit
.potxand.ppsxfiles open and save using their respective content types..pptm,.potm, and.ppsm) cannot be opened, including for viewing.