Skip to content

Docs: Play From and the .potx/.ppsx content types are no longer listed as missing - #1327

Merged
aiongg merged 1 commit into
storytold:mainfrom
dotCooCoo:fix/parity-docs-play-from-potx
Oct 25, 2026
Merged

aiongg merged 1 commit into
storytold:mainfrom
dotCooCoo:fix/parity-docs-play-from-potx

Conversation

@dotCooCoo

@dotCooCoo dotCooCoo commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Five parity rows and entries on main at 38d2ade describe features as missing that main already has.

  • docs/ui-parity.md, Animation Pane: the row said "no preview from the selected effect". With an effect selected the pane's button reads Play From and starts the preview at that effect (crates/ui-egui/src/panes.rs:1032, animpane_tests::play_from_starts_at_the_selected_effect). docs/animation-parity.md and docs/gaps.md already say so.
  • docs/gaps.md, docs/file-format-parity.md and docs/parity-checklist.md: these said .potx and .ppsx are saved with the .pptx content type. deckcraft_pptx::export_as writes the template and slide-show main content types (crates/pptx/src/lib.rs:82-90), and save_bytes in crates/engine/src/cmd/file.rs calls it for both formats. roundtrip.rs::templates_and_slide_shows_declare_their_own_main_content_type checks it.

What changes:

  • The Animation Pane row lists Play From.
  • The gaps.md entry covers only the macro-enabled .pptm/.potm/.ppsm files, which are still not read. Its estimate is unchanged.
  • The .potx and .ppsx rows of file-format-parity.md say yes in the write column, and the .potx row names crates/pptx/tests/it/roundtrip.rs as its test.
  • The checklist row says .potx/.ppsx save with their own content types. It stays partial for .pptm, and cargo xtask parity leaves the summary unchanged.

Status lines and revision histories are unchanged.

Open #523 (.pptm) rewrites the same gaps.md entry, and open #304 (templates) rewrites that entry and the two file-format-parity.md rows, so each of them conflicts with this change in those lines. Open #711 rewrites the Animation Pane row from an older base and also conflicts with this change; it already conflicts with main in docs/ui-parity.md and docs/gaps.md.

Checks: cargo xtask parity, which produced no change to the summary.

On Windows 11 (x86-64) with rustc 1.99.1, on top of main at 38d2ade, with #1292, #1298 and #1300 merged in:

  • cargo xtask ci passes its 8 steps: 1,880 tests passed, 0 failed, 6 ignored.

Without #1298, control_server::tests::a_pipelined_peer_still_reads_why_its_line_was_rejected fails intermittently on main at 38d2ade too (upstream CI fails it on that commit); #1298 fixes it.

git merge-tree reports no conflicts with main at 38d2ade.

Summary by CodeRabbit

  • Documentation
    • Clarified that .potx and .ppsx files open and save using their respective content types.
    • Updated the documented limitation that macro-enabled PowerPoint formats (.pptm, .potm, and .ppsm) cannot be opened, including for viewing.
    • Clarified that Play From starts animation playback at the selected effect.

…d as missing

The Animation Pane row in ui-parity.md said the pane cannot preview from
the selected effect, but its button reads Play From and starts there
(animpane_tests). gaps.md, file-format-parity.md and the parity checklist
said .potx and .ppsx are saved with the .pptx content type, but
deckcraft_pptx::export_as writes the template and slide-show content
types, as a test in crates/pptx/tests/it/roundtrip.rs checks. The
gaps.md entry now covers only the macro-enabled variants. The checklist
row stays partial, and cargo xtask parity leaves the summary unchanged.
@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 38d2ade and a9cafe6.

Files selected for processing: 4
  • docs/file-format-parity.md
  • docs/gaps.md
  • docs/parity-checklist.md
  • docs/ui-parity.md

Limit details: You’ve used all 10 included reviews currently available.

Walkthrough

The documentation now describes format-specific content types for .potx and .ppsx, identifies unsupported macro-enabled variants, and states that Play From starts at the selected animation effect.

Changes: PowerPoint format documentation

Layer / File(s) Summary
Format support and content types
docs/gaps.md, docs/file-format-parity.md, docs/parity-checklist.md
The documentation describes format-specific content types for .pptx, .potx, and .ppsx. It identifies .pptm, .potm, and .ppsm as unrecognized. The .potx and .ppsx entries include test references.

Animation Pane documentation

Layer / File(s) Summary
Play From behavior
docs/ui-parity.md
The Animation Pane entry states that Play From starts playback at the selected effect.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related PRs

Suggested reviewers: echelon

Merge Risk: Minimal · up to a9caf

No actionable merge-blocking risk remains.

Architecture risk: Low · up to a9caf

The change affects 1 system.

Changed systems: docs

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — docs (service) was modified; 4 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in docs/file-format-parity.md: The .potx and .ppsx entries change their write descriptions from .pptx content to their respective template and slide-show content types. The .potx test reference changes from none to crates/pptx/tests/it/roundtrip.rs; the .ppsx test reference is specified as crates/ui-egui/src/opening.rs.
  • observed — Modified behavior in docs/gaps.md: The entry now identifies .pptm, .potm and .ppsm as unrecognized, and says macro decks cannot be opened even for viewing. It replaces the claim that template, slide-show and macro variants are saved as plain .pptx, noting instead that .pptx, .potx and .ppsx open and save with their own main content types.
  • observed — Modified behavior in docs/parity-checklist.md: The checklist now says .potx and .ppsx variants open and save with their own content types, replacing the statement that saves used the .pptx content type. The .pptm limitation remains.
  • observed — Modified behavior in docs/ui-parity.md: The Animation Pane description adds that Play From starts at the selected effect and removes the prior statement that preview from the selected effect was unavailable.
Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names two of the changes in the PR, Play From and the .potx/.ppsx content types. Those are real parts of the changeset. The PR also updates gaps.md, file-format-parity.md, and parity-checkli…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names two of the changes in the PR, Play From and the .potx/.ppsx content types. Those are real parts of the changeset. The PR also updates gaps.md, file-format-parity.md, and parity-checklist.md, and the title does not mention the macro-enabled .pptm/.potm/.ppsm limitation. The title is partially related: it refers to real changes but is not fully comprehensive. Also, the title is accurate to the actual changes, as Play From is documented as present and the .potx/.ppsx content types are described correctly.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Usage-based review receipt

  • Mode: Continue automatically
  • Reviewed files: 4
  • Waived: $1.00 (charged $0.00)
  • View usage details

Note

This review exceeded your plan’s limits and used usage-based reviews—free during trial, billed after paid activation unless disabled. Manage usage-based reviews.

Comment @coderabbitai help to get the list of available commands.

@aiongg
aiongg merged commit da8db49 into storytold:main Oct 25, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants