Repository navigation
Conversation
Since the egui 0.37 migration (storytold#1350), eframe's OS clipboard is the opt-in `clipboard` feature. The desktop app turns eframe's default features off and did not list it, so egui-winit fell back to a clipboard simulated inside the app: copy and paste within DeckCraft still worked, but text copied in any other program never arrived on Ctrl+V. Enable `clipboard` on the desktop app's eframe (it also turns on egui-winit's `clipboard-image`). Cargo.lock gains smithay-clipboard and its Wayland dependencies. The v0.11.1 release predates storytold#1350 and is not affected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Review notes (read the diff, checked the feature wiring; I did not run a paste).
Not checked: actual paste of text from another app on Linux, Windows or macOS (needs an interactive session; WSLg's compositor is not representative anyway), and the build of the app binary here. |
|
Critical bug, merge asap pls |
|
This is critical, clipboard the most used feature in any toolkit, how is possible this is still not merge? |
|
@echelon can you pls approve this? deckcraft is almost thrash without copy and paste |
FredApps
left a comment
There was a problem hiding this comment.
ReviewerA — source-read COMMENT (not an approval)
I read the manifest hunk: the eframe clipboard feature is enabled for the desktop app so pasting from other applications works again. A feature flag on an existing dependency is a small change; the feature pulls in arboard and its platform dependencies, so check the lockfile (the new transitive dependencies' licences and the Wayland build) and that the CI builds on Linux with and without X11. I can't test paste between applications here.
I ran nothing and have no exact-head CI result for this PR, so this is not an approval. Where a diff was long I read its code hunks rather than every generated or documentation line.
Status: waiting_author.
There was a problem hiding this comment.
AI-generated review (Opus). Not a maintainer decision.
Significant problems found:
The main branch already has this fix. eframe's clipboard feature is enabled in apps/deckcraft/Cargo.toml:19 and the lockfile includes the clipboard crates, so after the base merge this branch has no changes left.
- apps/deckcraft/Cargo.toml:19 on main already lists
clipboardamong the eframe features, with a comment saying why it is needed. - Cargo.lock on main already has
arboardandsmithay-clipboard, so no lockfile change is left either. - The diagnosis was right: without the feature, egui-winit uses a clipboard simulated inside the app, so Ctrl+V only pastes what the app copied itself.
Claims checked:
- verified: Enabling eframe's
clipboardfeature in apps/deckcraft brings back pasting from other apps on the desktop (apps/deckcraft/Cargo.toml:19 lists "clipboard" in the eframe features; the comment at apps/deckcraft/Cargo.toml:17-18 says that without it egui simulates a clipboard inside the app. The defau… - unverified: The lockfile adds smithay-clipboard and its dependencies (Cargo.lock:210 (arboard) and Cargo.lock:4513 (smithay-clipboard) are present; the default branch has them too, so the PR adds nothing here any more.)
- verified: No code changes; the web app is untouched (The PR's diff against the current base is empty; apps/deckcraft/Cargo.toml:19 is the only relevant line and it already matches the base.)
Recommendation: wait for maintainer feedback.
Reviewed at 42aa8da.
|
AI-generated comment (Sonnet). Not a maintainer decision. Merged main into this branch to resolve the conflict. |
Summary
On
main, text copied in another program doesn't paste into the desktop app with Ctrl+V or Edit ▸ Paste. Copy and paste within DeckCraft still works. This is a regression from the egui 0.37 migration (#1350). The v0.11.1 release predates #1350, so released builds are not affected.Cause
In the egui fork that #1350 moved to, eframe's access to the OS clipboard is the opt-in
clipboardfeature (it enablesegui-winit/clipboardandegui-winit/clipboard-image).apps/deckcraftturns off eframe's default features and lists its own, andclipboardwasn't among them.Without that feature, egui-winit uses a clipboard simulated inside the process. A Ctrl+V therefore only ever delivers what DeckCraft itself copied.
cargo tree -e features -i egui-winitonmainshows noclipboardfeature enabled.Change
apps/deckcraft/Cargo.toml: add"clipboard"to the eframe features.Cargo.lock: addssmithay-clipboardand its Wayland dependencies, which egui-winit's clipboard pulls in.No code changes. The web app (
apps/deckcraft-web) is untouched.Related
persistence). Whichever of the two merges second gets a one-line conflict; keep both features.main.Testing
cargo build --release --locked -p deckcraft,cargo clippy --locked -p deckcraft --all-targets -D warnings,cargo fmt --checkandcargo test -p deckcraft(44 tests)all pass.cargo tree -e features -i egui-winitnow listsegui-winit feature "clipboard".🤖 Generated with Claude Code
Summary by CodeRabbit