Repository navigation
refactor(ui): use craft-ui's ComboBox for every dropdown - #1457
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Dependency and lint setup Cargo.toml, clippy.toml, crates/ui-egui/Cargo.toml, xtask/src/pdf_deps.rs |
The craft dependencies, the krilla patch, and the PDF dependency revision use craft-libs revision 92d392c. The UI crate adds craft-ui, and Clippy disallows egui::ComboBox. |
Backstage and dialog selectors crates/ui-egui/src/backstage/*, crates/ui-egui/src/dialogs* |
Existing selectors use craft_ui::ComboBox instead of egui::ComboBox. Their existing options and selection logic remain unchanged. |
Panel and ribbon selectors crates/ui-egui/src/panels/*, crates/ui-egui/src/ribbon/transitions.rs |
Existing selectors use craft_ui::ComboBox instead of egui::ComboBox. Their options and selection handling remain unchanged. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Suggested reviewers: skylartaylor, dylanmtaylor, echelon
Merge Risk: 
Minimal · up to 0d9ff
-
No actionable merge risk was found; the change is ready to merge.
Security architecture risk: 
Low · up to 0d9ff
-
The inspected changes preserve caller-owned selections and existing PDF dependency checks. No new externally reachable interface or weakened control was identified. The dependency update also affects media, PDF, and update functionality; changes within those upstream components were not fully assessed.
Retained concerns
No architecture-level concerns identified.Security review details
-
Security Blast Radius
- observed — The dependency revision change reaches media, PDF generation, and update packages as well as the newly adopted UI package. Its dependency scope is therefore broader than dropdown rendering alone.
Trust Boundaries and Controls
- inferred — The SHARED_REV change does not introduce an attacker-controlled command parameter or a new runtime entrypoint: it supplies a fixed expected source string to the existing developer-tool validation path. This conclusion is limited to the inspected checker and its callers, not upstream dependency behavior.
-
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 19 functions across 16 files.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Usage-based review receipt
- Mode: Continue automatically
- Reviewed files: 1
- Waived: $0.25 (charged $0.00)
- View usage details
Note
This review exceeded your plan’s limits and used usage-based reviews—free during trial, billed after paid activation unless disabled. Manage usage-based reviews.
Comment @coderabbitai help to get the list of available commands.
egui's
ComboBoxcaps its menu at the previous frame's height, so a menu that shrinks while open never grows back (emilk/egui#5225). craft-libs#387 addscraft_ui::ComboBoxandcombo::Menu, which do not have this cap.Changes:
ComboBoxuses swapped tocraft_ui::ComboBox. None is searchable, so this is a plain swap. The Add Animation menu (deckcraft#1370) is not touched.craft-uiadded as a dependency.disallowed-typesrule rejectsegui::ComboBox.No new tests. Clippy is clean on ui-egui, pdf, media, engine and app.
Tested on macOS: Backstage > Print paper size and orientation; Insert Date/Time language list; Format Shape combos; Transitions sound.
Summary by CodeRabbit