Repository navigation
Animations: fix Darken and Desaturate preset ids and 14 default durations - #1467
Conversation
… shift, and 14 effects get its default durations
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Animation preset IDs and default durations crates/model/src/anim.rs, crates/pptx/tests/it/roundtrip.rs |
Default durations change for several animation effects. The preset IDs for darken and desaturate change. Tests assert expected durations. |
PPTX effect mappings and color shifts crates/pptx/src/maps.rs, crates/pptx/src/write/timing.rs, crates/pptx/tests/it/roundtrip.rs |
PPTX mappings use the updated preset IDs. Export writes relative HSL shifts for darken and desaturate. Tests check the XML attributes and round-trip effect names. |
Priority:
Estimated code review effort: 2 (Simple) | ~15 minutes
Change: Bug fix
Suggested reviewers: echelon, aiongg
Merge Risk: 
Minimal · up to 1e842
-
No confirmed issue blocks merging. Playback of Darken and Desaturate on explicitly colored text has not been verified.
Security architecture risk: 
Minimal · up to 1e842
-
The changes correct animation metadata and color encoding without adding executable entrypoints or expanding access to data or services. No material security regression was identified in the reviewed paths.
Retained concerns
No architecture-level concerns identified.Security review details
-
Security Blast Radius
- inferred — The changed behavior affects animation interpretation and generated color timing for referenced presentation shapes. The new branch emits three fixed color-property behaviors per resolved effect; it does not introduce another asset target or an external execution destination.
Security Findings and Attack Paths
- inferred — Document-supplied preset identifiers still pass through the existing timing reader and catalog mapper. The corrected identifiers select animation semantics, while the new export branch produces fixed XML color shifts. No new command-execution or privilege-bearing path was identified in this flow.
Trust Boundaries and Controls
- observed — The new HSL path preserves existing shape/paragraph targeting and clamps behavior duration to 1–3,600,000 milliseconds. Its property names and HSL shift values are constants rather than document-supplied expressions.
Resilience and Maintainability Implications
- observed — The added branch reads borrowed animation data and advances identifiers owned by the current timing-export call. It does not mutate the presentation model or introduce shared persistent state, reservations, or a new recovery transition.
-
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passedFull details: Docstring Coverage
-
Explanation
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 4 functions across 4 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Usage-based review receipt
- Mode: Continue automatically
- Reviewed files: 4
- Waived: $1.00 (charged $0.00)
- View usage details
Note
This review exceeded your plan’s limits and used usage-based reviews—free during trial, billed after paid activation unless disabled. Manage usage-based reviews.
Comment @coderabbitai help to get the list of available commands.
|
Landed on main, thank you @Harrison-Booth for the contribution! If you haven't already, come join us on Discord: https://discord.gg/artcraft |
Darken and Desaturate used the wrong preset ids, and 14 effects got a different default duration from PowerPoint's.
What changed
animClr clrSpc="hsl"withby, lightness -25098 for Darken, saturation -70588 for Desaturate) on text, fill and line colour. Before, Darken wrote a colour change to accent 2 and Desaturate wrote a 110% scale.AddEffectdefaults: Grow & Turn, Shrink & Turn, Expand, Contract 1 s; Box, Circle, Diamond (in and out) and Bold Flash 2 s; Spinner in and out and Object Color 0.5 s; Color Pulse 0.25 s.Not changed
Transparency's default in PowerPoint is "until end of slide" (indefinite). The model has no value for that, so it stays at 0.5 s.
Checked
main.cargo testfor deckcraft-pptx, deckcraft-anim and deckcraft-model passes.cargo fmt --checkis clean.AddEffectgives the same defaults.Summary by CodeRabbit