Skip to content

Dark theme: checkboxes and slider rails stand out in Preferences (#1349) - #1472

Closed
Harrison-Booth wants to merge 1 commit into
storytold:mainfrom
Harrison-Booth:dc-light-mode-checks
Closed

Harrison-Booth wants to merge 1 commit into
storytold:mainfrom
Harrison-Booth:dc-light-mode-checks

Conversation

@Harrison-Booth

Copy link
Copy Markdown
Contributor

Fixes #1349. The screenshot in the issue shows the dark theme, not light: the Preferences checkboxes and the Interface size rail are filled with control (0x2A) on a 0x33 dialog, a 9-step difference that is nearly invisible. #766 already fixed the light fills on main, so #930 (which lightens the light field_bg) does not address this report.

  • Dark control, control_hover and control_pressed are now 0x58, 0x66 and 0x74: at least 24 steps from the dialog and the panel, and lightening on hover and press. Only theme.rs uses these tokens.
  • New test dark_checkboxes_and_slider_rails_stand_out_from_their_background mirrors the light one.
  • docs/animation-parity.md: records the 2026-10-27 PowerPoint re-check that all 145 DeckCraft-written transition slides open with a non-zero EntryEffect and re-save with the same element (the 32 differences are only PowerPoint dropping default attributes). No new test: the round-trip tests already cover this.

What ran: cargo test -p deckcraft-ui-egui --lib theme (19 passed) and cargo fmt --check on Linux. Not run: a visual check on Windows or WSLg, and the full CI suite.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

interface size slider and dark mode toggle is invisible in windows with dark appearance off v0.10.0

1 participant