Repository navigation
Dark theme: checkboxes and slider rails stand out in Preferences (#1349) - #1472
Closed
Harrison-Booth wants to merge 1 commit into
Closed
Harrison-Booth wants to merge 1 commit into
Harrison-Booth wants to merge 1 commit into
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1349. The screenshot in the issue shows the dark theme, not light: the Preferences checkboxes and the Interface size rail are filled with
control(0x2A) on a 0x33 dialog, a 9-step difference that is nearly invisible. #766 already fixed the light fills on main, so #930 (which lightens the lightfield_bg) does not address this report.control,control_hoverandcontrol_pressedare now 0x58, 0x66 and 0x74: at least 24 steps from the dialog and the panel, and lightening on hover and press. Onlytheme.rsuses these tokens.dark_checkboxes_and_slider_rails_stand_out_from_their_backgroundmirrors the light one.docs/animation-parity.md: records the 2026-10-27 PowerPoint re-check that all 145 DeckCraft-written transition slides open with a non-zero EntryEffect and re-save with the same element (the 32 differences are only PowerPoint dropping default attributes). No new test: the round-trip tests already cover this.What ran:
cargo test -p deckcraft-ui-egui --lib theme(19 passed) andcargo fmt --checkon Linux. Not run: a visual check on Windows or WSLg, and the full CI suite.