Repository navigation
Fix update testing and dev-only testkit layer checks - #1562
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Update craft-update revision Cargo.toml |
The craft-update revision changes. The adjacent comment describes app-specific pretend versions for startup and manual checks. |
Testkit layer validation
| Layer / File(s) | Summary |
|---|---|
Allow testkit dev-dependencies across layers xtask/src/layers.rs |
check skips layer-order validation for deckcraft-testkit dev-dependencies after the existing check for non-dev testkit violations. |
Contributor record
| Layer / File(s) | Summary |
|---|---|
Add contributor profile settings contributors/people.toml |
A people.dylanmtaylor entry enables syncing the display name from the GitHub profile. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Suggested reviewers: echelon
Merge Risk: 
Minimal · up to d1631
-
The dependency update and layer-check exception present no identified merge-blocking risk.
Architecture risk: 
Low · up to d1631
-
The change affects 3 systems.
Changed systems:
xtask,Cargo.toml,contributorsArchitecture concerns
No architecture-level concerns identified.Review details
-
Systems and components
- observed — xtask (service) was modified; 1 changed file maps to changed impact.
- observed — Cargo.toml (service) was modified; 1 changed file maps to changed impact.
- observed — contributors (service) was modified; 1 changed file maps to changed impact.
Before / after behavior
- observed — Modified behavior in contributors/people.toml: Added the
people.dylanmtaylortable and enabled syncing the display name from the GitHub profile. - observed — Modified behavior in Cargo.toml: Updated the
craft-updatecomment and Git revision; the dependency’s exact version requirement andeguifeature are unchanged. - observed — Modified behavior in xtask/src/layers.rs:
checknow skips layer-order validation forClass::Testkitdependencies after the existing non-dev testkit violation check. Thus, testkit dev-dependencies are allowed regardless of layer; previously they were evaluated by the ordinary layer-ordering rules.
-
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Usage-based review receipt
- Mode: Continue automatically
- Reviewed files: 2
- Waived: $0.50 (charged $0.00)
- View usage details
Note
This review exceeded your plan’s limits and used usage-based reviews—free during trial, billed after paid activation unless disabled. Manage usage-based reviews.
Comment @coderabbitai help to get the list of available commands.
b94e126 to
d163180
Compare
Native startup and manual checks ignored
DECKCRAFT_PRETEND_VERSION, so test launches could fail to show an update. Pin craft-update to the reviewed merge commit04aa1703b32d299e54f78fcde4182f2b393a9116from storytold/craft-libs#436, which is now merged. The shared fix resolves the pretend version for checks and prompt display, preserves the explicit opt-in installation test mode, and clears overrides on restart, including persistent Flatpak overrides.The app retains its existing icon, accent and developer branding. Dylan opted into syncing his public GitHub profile name for contributor credits; only his own people.toml entry is added, committed as him. Per docs/contributors.md, names become visible after the next normal maintainer refresh of generated contributor data.
Validation:
cargo tree -p craft-update --locked --depth 0resolves exactly the merged revision. Shared library CI passed on Ubuntu and Windows. Local Linux library tests: 244 with egui and 214 without (3 ignored in each). All 13 app identities have isolated regression coverage for startup prompts and explicit installation-test version overrides. LightCraft was built and launched with its pretend version; the real prompt showedv0.0.1 to 0.15.0, its amber accent, icon and by ArtCraft branding.Initial full CI exposed a pre-existing fallthrough in the layer checker: dev-only testkit dependencies were incorrectly rejected as upward dependencies. Restore the documented testkit dev-dependency exception while continuing to reject normal/build testkit use and other upward dependencies. The original regression tests reproduce the failure; all 11 layer tests now pass, with Clippy and formatting clean. Final full CI must pass before merge.
GitHub CI and CodeRabbit must both pass on this final app commit before merge.
Test from this app checkout:
Summary by CodeRabbit