You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Preserve centered anchoring on table cells - #1709
No actionable comments were generated in the recent review.
Walkthrough
The cell model now stores optional anchor centering. PPTX import reads the anchorCtr attribute, and PPTX export writes it. A regression test checks that the value survives two PPTX round trips.
Changes: Table-cell anchor centering
Layer / File(s)
Summary
Model and PPTX anchor-centering round trip crates/model/src/table.rs, crates/pptx/src/read/shapes.rs, crates/pptx/src/write/shapes.rs, crates/pptx/tests/it/roundtrip.rs
Cell adds the optional anchor_ctr field. The PPTX reader imports anchorCtr from tcPr, and the writer emits it in a:tcPr. A regression test checks that Some(true) remains set after two round trips.
Issue 1044 reports unusable table handling. This change preserves the specific anchorCtr setting when importing and exporting PPTX tables.
Suggested reviewers:echelon, aiongg
Merge Risk: Minimal · up to b66ba
The change preserves table-cell anchoring across PPTX round trips without an identified merge-blocking risk.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: preserving centered anchoring on table cells during PPTX round trips.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 3 functions across 4 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between 0c00f22 and b66ba2e.
Files selected for processing: 4
crates/model/src/table.rs
crates/pptx/src/read/shapes.rs
crates/pptx/src/write/shapes.rs
crates/pptx/tests/it/roundtrip.rs
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserves centered text anchoring on table cells through PPTX import and export. A regression test checks the value after two round trips.
Validation:
cargo fmt --all -- --checkand the focused PPTX round-trip test passed on Linux. Windows and macOS were not run.Summary by CodeRabbit