Skip to content

Preserve centered anchoring on table cells - #1709

Merged
h-a-n-a-s-h-i merged 1 commit into
storytold:mainfrom
Harrison-Booth:dc-build-d711
Nov 3, 2026
Merged

h-a-n-a-s-h-i merged 1 commit into
storytold:mainfrom
Harrison-Booth:dc-build-d711

Conversation

@Harrison-Booth

@Harrison-Booth Harrison-Booth commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Preserves centered text anchoring on table cells through PPTX import and export. A regression test checks the value after two round trips.

Validation: cargo fmt --all -- --check and the focused PPTX round-trip test passed on Linux. Windows and macOS were not run.

Summary by CodeRabbit

  • Bug Fixes
    • Preserved vertical centering for table-cell content when importing and exporting PowerPoint presentations.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The cell model now stores optional anchor centering. PPTX import reads the anchorCtr attribute, and PPTX export writes it. A regression test checks that the value survives two PPTX round trips.

Changes: Table-cell anchor centering

Layer / File(s) Summary
Model and PPTX anchor-centering round trip
crates/model/src/table.rs, crates/pptx/src/read/shapes.rs, crates/pptx/src/write/shapes.rs, crates/pptx/tests/it/roundtrip.rs
Cell adds the optional anchor_ctr field. The PPTX reader imports anchorCtr from tcPr, and the writer emits it in a:tcPr. A regression test checks that Some(true) remains set after two round trips.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Possibly related issues

  • Issue 1044 reports unusable table handling. This change preserves the specific anchorCtr setting when importing and exporting PPTX tables.

Suggested reviewers: echelon, aiongg

Merge Risk: Minimal · up to b66ba

The change preserves table-cell anchoring across PPTX round trips without an identified merge-blocking risk.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: preserving centered anchoring on table cells during PPTX round trips.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 3 functions across 4 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 0c00f22 and b66ba2e.

Files selected for processing: 4
  • crates/model/src/table.rs
  • crates/pptx/src/read/shapes.rs
  • crates/pptx/src/write/shapes.rs
  • crates/pptx/tests/it/roundtrip.rs

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.

@h-a-n-a-s-h-i
h-a-n-a-s-h-i merged commit ed62aaf into storytold:main Nov 3, 2026
7 checks passed
@echelon

echelon commented Nov 3, 2026

Copy link
Copy Markdown
Member

Thanks @Harrison-Booth, landed on main as part of today's community batch.

If you haven't already, come join us on Discord: https://discord.gg/artcraft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants