Skip to content

Reuse custom table styles with reused slides - #1719

Merged
h-a-n-a-s-h-i merged 2 commits into
storytold:mainfrom
Harrison-Booth:dc-build-d705
Nov 3, 2026
Merged

h-a-n-a-s-h-i merged 2 commits into
storytold:mainfrom
Harrison-Booth:dc-build-d705

Conversation

@Harrison-Booth

Copy link
Copy Markdown
Contributor

Slides reused from another presentation now keep the custom table styles their tables reference, including tables inside groups. Identical definitions are shared; a conflicting style ID is remapped for the imported table so existing destination tables keep their style.

Regression tests cover native and PPTX sources, Keep Source Formatting, grouped tables, undo/redo, native save/reopen, and identical and conflicting IDs. The engine test suite passes on Linux and Windows.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 24 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 8 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 0c00f22 and 63531e2.

Files selected for processing: 4
  • ROADMAP.md
  • crates/engine/src/cmd/reuse.rs
  • docs/file-format-parity.md
  • docs/parity-checklist.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@h-a-n-a-s-h-i
h-a-n-a-s-h-i merged commit 63531e2 into storytold:main Nov 3, 2026
7 checks passed
h-a-n-a-s-h-i pushed a commit that referenced this pull request Nov 3, 2026
@echelon

echelon commented Nov 3, 2026

Copy link
Copy Markdown
Member

Thanks @Harrison-Booth, landed on main as part of today's community batch. Before landing I added one small commit: when a style id is remapped, the styleId inside the definition's XML is renamed too (PPTX export writes that XML verbatim), and the checklist row keeps its feature name.

If you haven't already, come join us on Discord: https://discord.gg/artcraft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants