Skip to content

Fit reused slides to the destination size - #1720

Merged
h-a-n-a-s-h-i merged 1 commit into
storytold:mainfrom
Harrison-Booth:dc-build-d707
Nov 3, 2026
Merged

h-a-n-a-s-h-i merged 1 commit into
storytold:mainfrom
Harrison-Booth:dc-build-d707

Conversation

@Harrison-Booth

Copy link
Copy Markdown
Contributor

Slides reused from another deck now fit the current slide size, including groups, tables, text, and source master and layout geometry when keeping formatting. This keeps imported content in the same relative positions when the source and destination sizes differ.

A regression checks the half-size placement, table grid, text size, group children, imported masters and layouts, and save/reopen. The full engine suite and clippy pass on Linux; the focused regression also passes on Windows. macOS was not run.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 24 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 8 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 0c00f22 and bf60dbb.

Files selected for processing: 5
  • ROADMAP.md
  • crates/engine/src/cmd/reuse.rs
  • docs/gaps.md
  • docs/parity-checklist.md
  • docs/target-app-parity.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@h-a-n-a-s-h-i
h-a-n-a-s-h-i merged commit bf60dbb into storytold:main Nov 3, 2026
7 checks passed
h-a-n-a-s-h-i pushed a commit that referenced this pull request Nov 3, 2026
# Conflicts:
#	crates/engine/src/cmd/reuse.rs
@echelon

echelon commented Nov 3, 2026

Copy link
Copy Markdown
Member

Thanks @Harrison-Booth, landed on main as part of today's community batch. Before landing I added one small commit: a non-finite size ratio leaves content unscaled, the test now checks a table cell's text size, and the doc history lines (#1693, #1103) are kept.

If you haven't already, come join us on Discord: https://discord.gg/artcraft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants