Skip to content

Preserve alternate run language - #1722

Merged
h-a-n-a-s-h-i merged 1 commit into
storytold:mainfrom
Harrison-Booth:dc-build-d706
Nov 3, 2026
Merged

h-a-n-a-s-h-i merged 1 commit into
storytold:mainfrom
Harrison-Booth:dc-build-d706

Conversation

@Harrison-Booth

Copy link
Copy Markdown
Contributor

Text runs now retain an alternate language independently of the main language through native and PowerPoint file saves. Existing language metadata remains unchanged, and files without an alternate language stay compact.

Round-trip tests check distinct en-US and fr-FR values, absent values, inheritance, bounded native input, and two save/reopen cycles in both formats. Scoped tests and clippy pass with CI’s pinned font checkout.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 23 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 8 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 0c00f22 and a0956fe.

Files selected for processing: 8
  • ROADMAP.md
  • crates/format/src/tests.rs
  • crates/model/src/text.rs
  • crates/pptx/src/read/dml.rs
  • crates/pptx/src/write/dml.rs
  • crates/pptx/tests/it/roundtrip.rs
  • docs/file-format-parity.md
  • docs/gaps.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@h-a-n-a-s-h-i
h-a-n-a-s-h-i merged commit 996ca4d into storytold:main Nov 3, 2026
7 checks passed
@echelon

echelon commented Nov 3, 2026

Copy link
Copy Markdown
Member

Thanks @Harrison-Booth, landed on main as part of today's community batch.

If you haven't already, come join us on Discord: https://discord.gg/artcraft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants