Skip to content

fix: enable native clipboard support - #1750

Closed
Jagx-mf wants to merge 1 commit into
storytold:mainfrom
Jagx-mf:fix/presenter-notes-paste
Closed

Jagx-mf wants to merge 1 commit into
storytold:mainfrom
Jagx-mf:fix/presenter-notes-paste

Conversation

@Jagx-mf

@Jagx-mf Jagx-mf commented Nov 3, 2026 •

Copy link
Copy Markdown

Problem

Copying and pasting text from external applications into presenter notes does not work in DeckCraft 0.15.0 on Ubuntu Linux.

Text can be entered manually, but Ctrl+V does not paste text from the system clipboard.

Root Cause

The native application does not enable the clipboard feature of eframe.

Without this feature, egui uses a simulated internal clipboard instead of accessing the operating system clipboard.

Solution

Enable the clipboard feature in apps/deckcraft/Cargo.toml.

Update Cargo.lock to include the required dependencies.

No changes were made to the keyboard event handling or context menus.

Validation

  • cargo check -p deckcraft — Passed
  • cargo build --locked -p deckcraft — Passed
  • Manual testing on Ubuntu Linux — Passed
  • Copying and pasting text in presenter notes — Working

Result

Native clipboard integration is now enabled, allowing presenter notes to exchange text with external applications.

Summary by CodeRabbit

  • New Features
    • Deckcraft now supports clipboard integration, making clipboard functionality available within the app.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The eframe dependency now enables its clipboard feature. Its existing features remain unchanged.

Changes: Clipboard support

Layer / File(s) Summary
Enable eframe clipboard feature
apps/deckcraft/Cargo.toml
The eframe feature list adds clipboard. Existing features remain unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Possibly related issues

Suggested reviewers: alexanderalber

Merge Risk: Minimal · up to 223e1

No merge-blocking risk is evident; the clipboard feature change is ready for normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: enabling native clipboard support for DeckCraft.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 82ec813 and 223e1b2.

Files ignored due to path filters: 1
  • Cargo.lock is excluded by !**/*.lock
Files selected for processing: 1
  • apps/deckcraft/Cargo.toml

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

@aiongg aiongg added the bugfix Fixes something that is broken: wrong result, crash, data loss label Nov 4, 2026

@eliets2 eliets2 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First-pass review notes (automated; combined from specialist angles: tests). Please treat as suggestions and verify before acting.

What it does: This change enables native clipboard support in DeckCraft by turning on the clipboard feature of eframe, so presenter notes can copy and paste text with external applications instead of using egui's simulated internal clipboard.

Logical units:

  • Enable the clipboard feature for eframe in apps/deckcraft/Cargo.toml
  • Update Cargo.lock with the new clipboard dependencies, including smithay-clipboard and calloop 0.14.5

Findings:

  • [tests] apps/deckcraft/Cargo.toml, eframe feature list: No automated regression test covers copy/paste in presenter notes, and validation is manual testing on Ubuntu only, so removal of the clipboard feature or a clipboard backend regression would not be caught automatically. Add a clipboard set/get round-trip test for the notes field, using a mocked clipboard where the OS clipboard is unavailable, and a check that the feature remains enabled.
  • [tests] Cargo.lock, new smithay-clipboard/calloop 0.14.5 and platform clipboard dependencies: The change adds Wayland, macOS, and Windows clipboard backends, but no build or test evidence is provided for those platforms. Add CI builds/tests for Windows and macOS, and for Linux on both Wayland and X11, before merging.

Verdict: needs changes

  1. Add an automated clipboard set/get round-trip test for presenter notes with a mocked clipboard.
  2. Add a check that the clipboard feature remains enabled.
  3. Add CI build/test evidence for Windows, macOS, and Linux on Wayland and X11.

@skylartaylor

Copy link
Copy Markdown
Member

Your diagnosis is what landed: apps/deckcraft/Cargo.toml:19 now lists clipboard in eframe's features, added in cbb0c48 and merged as #1658 (2b6d27d, 2026-11-05). Apart from the lockfile that flag is the whole diff here, so there's nothing left to land and I'm closing it as already fixed.

Thanks for writing the root cause down — the merged commit names the same egui 0.37 migration. That restores the OS clipboard on Linux; I haven't tried presenter-notes paste on Ubuntu myself, so if Ctrl+V still comes up empty for you on current main, comment here and I'll reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixes something that is broken: wrong result, crash, data loss

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants