Repository navigation
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
eliets2
left a comment
There was a problem hiding this comment.
First-pass review notes (automated; combined from specialist angles: tests). Please treat as suggestions and verify before acting.
What it does: This change enables native clipboard support in DeckCraft by turning on the clipboard feature of eframe, so presenter notes can copy and paste text with external applications instead of using egui's simulated internal clipboard.
Logical units:
- Enable the
clipboardfeature foreframeinapps/deckcraft/Cargo.toml - Update
Cargo.lockwith the new clipboard dependencies, includingsmithay-clipboardandcalloop 0.14.5
Findings:
- [tests]
apps/deckcraft/Cargo.toml,eframefeature list: No automated regression test covers copy/paste in presenter notes, and validation is manual testing on Ubuntu only, so removal of theclipboardfeature or a clipboard backend regression would not be caught automatically. Add a clipboard set/get round-trip test for the notes field, using a mocked clipboard where the OS clipboard is unavailable, and a check that the feature remains enabled. - [tests]
Cargo.lock, newsmithay-clipboard/calloop 0.14.5and platform clipboard dependencies: The change adds Wayland, macOS, and Windows clipboard backends, but no build or test evidence is provided for those platforms. Add CI builds/tests for Windows and macOS, and for Linux on both Wayland and X11, before merging.
Verdict: needs changes
- Add an automated clipboard set/get round-trip test for presenter notes with a mocked clipboard.
- Add a check that the
clipboardfeature remains enabled. - Add CI build/test evidence for Windows, macOS, and Linux on Wayland and X11.
|
Your diagnosis is what landed: Thanks for writing the root cause down — the merged commit names the same egui 0.37 migration. That restores the OS clipboard on Linux; I haven't tried presenter-notes paste on Ubuntu myself, so if Ctrl+V still comes up empty for you on current main, comment here and I'll reopen. |
Problem
Copying and pasting text from external applications into presenter notes does not work in DeckCraft 0.15.0 on Ubuntu Linux.
Text can be entered manually, but Ctrl+V does not paste text from the system clipboard.
Root Cause
The native application does not enable the
clipboardfeature ofeframe.Without this feature, egui uses a simulated internal clipboard instead of accessing the operating system clipboard.
Solution
Enable the
clipboardfeature inapps/deckcraft/Cargo.toml.Update
Cargo.lockto include the required dependencies.No changes were made to the keyboard event handling or context menus.
Validation
cargo check -p deckcraft— Passedcargo build --locked -p deckcraft— PassedResult
Native clipboard integration is now enabled, allowing presenter notes to exchange text with external applications.
Summary by CodeRabbit