You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Engine: use sets for slide ranges, added slide selection and repeated-word offsets - #1756
Three engine paths checked membership by scanning a growing vector:
parse_slide_range: used out.contains(&i) for every index of every range. A broad range, or the same range repeated, was quadratic.
slide.select with add: scanned the selection for every supplied id.
review.spelling: searched the vector of repeated-word offsets for every word of a paragraph.
What changed
Each check is now a HashSet, and the vectors keep their order. Added a test: 200 copies of a 100,000-slide range expand to 100,000 indices in order, and a mixed "3, 1-3, 2" keeps first-seen order.
Blast radius
deckcraft-enginefile.export/print slide ranges, slide.select, and review.spelling. The results are identical.
No actionable comments were generated in the recent review.
Walkthrough
Three command paths now use HashSet membership checks for duplicate or repeated values. Slide-range parsing retains first-seen order and has a test for large repeated ranges, overlapping ranges, and repeated indices.
Slide-range parsing and slide selection use sets to track values already added. Repeated-word filtering stores word start positions in a set. The slide-range test checks ascending order and duplicate suppression.
No actionable merge-blocking risk is identified in the supplied change context.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names the three changed areas: slide range expansion, slide selection, and repeated-word offsets, all switched to set-based membership checks. The raw summary and objectives confirm this is …
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the three changed areas: slide range expansion, slide selection, and repeated-word offsets, all switched to set-based membership checks. The raw summary and objectives confirm this is the main change. It is a long title, but it is accurate and specific.
Full details: Docstring Coverage
Explanation
Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 3 functions across 3 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between 82ec813 and 8114eb8.
Files selected for processing: 3
crates/engine/src/cmd/file.rs
crates/engine/src/cmd/review.rs
crates/engine/src/cmd/slide.rs
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 3 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Three engine paths checked membership by scanning a growing vector:
parse_slide_range: usedout.contains(&i)for every index of every range. A broad range, or the same range repeated, was quadratic.slide.selectwithadd: scanned the selection for every supplied id.review.spelling: searched the vector of repeated-word offsets for every word of a paragraph.What changed
Each check is now a
HashSet, and the vectors keep their order. Added a test: 200 copies of a 100,000-slide range expand to 100,000 indices in order, and a mixed"3, 1-3, 2"keeps first-seen order.Blast radius
deckcraft-enginefile.export/print slide ranges,slide.select, andreview.spelling. The results are identical.Checks run
cargo fmt -p deckcraft-engine --checkcargo clippy -p deckcraft-engine --all-targets -- -D warningscargo test -p deckcraft-engineChecks not run
cargo xtask ciSummary by CodeRabbit