Skip to content

Engine: use sets for slide ranges, added slide selection and repeated-word offsets - #1756

Merged
dylanmtaylor merged 1 commit into
mainfrom
fix/sec-engine-small-sets
Nov 4, 2026
Merged

dylanmtaylor merged 1 commit into
mainfrom
fix/sec-engine-small-sets

Conversation

@dylanmtaylor

@dylanmtaylor dylanmtaylor commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

What was wrong

Three engine paths checked membership by scanning a growing vector:

  • parse_slide_range: used out.contains(&i) for every index of every range. A broad range, or the same range repeated, was quadratic.
  • slide.select with add: scanned the selection for every supplied id.
  • review.spelling: searched the vector of repeated-word offsets for every word of a paragraph.

What changed

Each check is now a HashSet, and the vectors keep their order. Added a test: 200 copies of a 100,000-slide range expand to 100,000 indices in order, and a mixed "3, 1-3, 2" keeps first-seen order.

Blast radius

deckcraft-engine file.export/print slide ranges, slide.select, and review.spelling. The results are identical.

Checks run

  • cargo fmt -p deckcraft-engine --check
  • cargo clippy -p deckcraft-engine --all-targets -- -D warnings
  • cargo test -p deckcraft-engine

Checks not run

  • The full cargo xtask ci

Summary by CodeRabbit

  • Performance
    • Improved handling of large or repeated slide ranges and slide selections.
    • Improved repeated-word checking during spelling reviews.
  • Behavior
    • Slide ranges and selections continue to preserve their existing order and avoid duplicate entries.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

Three command paths now use HashSet membership checks for duplicate or repeated values. Slide-range parsing retains first-seen order and has a test for large repeated ranges, overlapping ranges, and repeated indices.

Changes: Membership checks

Layer / File(s) Summary
Set-based duplicate tracking
crates/engine/src/cmd/file.rs, crates/engine/src/cmd/review.rs, crates/engine/src/cmd/slide.rs
Slide-range parsing and slide selection use sets to track values already added. Repeated-word filtering stores word start positions in a set. The slide-range test checks ascending order and duplicate suppression.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Suggested reviewers: nikitkara, echelon

Merge Risk: Minimal · up to 8114e

No actionable merge-blocking risk is identified in the supplied change context.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the three changed areas: slide range expansion, slide selection, and repeated-word offsets, all switched to set-based membership checks. The raw summary and objectives confirm this is …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the three changed areas: slide range expansion, slide selection, and repeated-word offsets, all switched to set-based membership checks. The raw summary and objectives confirm this is the main change. It is a long title, but it is accurate and specific.

Full details: Docstring Coverage

Explanation

Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 3 functions across 3 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 82ec813 and 8114eb8.

Files selected for processing: 3
  • crates/engine/src/cmd/file.rs
  • crates/engine/src/cmd/review.rs
  • crates/engine/src/cmd/slide.rs

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 3 remain after this review.

@dylanmtaylor
dylanmtaylor merged commit c6b7de4 into main Nov 4, 2026
9 of 10 checks passed
@dylanmtaylor
dylanmtaylor deleted the fix/sec-engine-small-sets branch November 4, 2026 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant