Repository navigation
PDF: map each glyph to its shaping cluster's text in ToUnicode (#164) - #178
Merged
Merged
Conversation
MarekSpodBiedry
marked this pull request as ready for review
October 11, 2026 21:46
h-a-n-a-s-h-i
pushed a commit
that referenced
this pull request
Oct 14, 2026
- #178: ToUnicode ranges looked up without indexing - #465: frame_num gaps are concealed (bounded) even when the SPS forbids them; cut streams keep playing - #471: control request lines up to 256 MB so picture/media inserts still fit - #473: a merge that loses its only row or column is removed, with regression tests - #521: AutoCorrect no longer rewrites real words (cant, wont, im) - #654: inherit_placeholder_geometry's doc comment back on its function Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Thank you for this contribution, @MarekSpodBiedry! It has landed on If you haven't already, please come join us on Discord: https://discord.gg/artcraft |
itrycodinganditsbad
added a commit
to itrycodinganditsbad/deckcraft
that referenced
this pull request
Oct 15, 2026
The start screen is now the File tab (New, Open › Browse, Recent), so the build and open guides use those labels. The FXC (storytold#176), transition duration (storytold#149), PDF text (storytold#178) and PPTX round-trip fixes are merged but not in 0.7.0, so the pages say that instead of "open". Every page is now verified: 0.7.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
anishguduru
pushed a commit
to anishguduru/deckcraft
that referenced
this pull request
Oct 16, 2026
storytold#178) * storytold#163: allow replacing saved signatures and render long names fully Add saved signature and initials previews with change/remove/add controls in Fill & Sign. Preserve placed annotations and saved values on cancellation. Use bounded line outlines for long names and fit typed placements to 150 pt. Co-authored-by: Codex <noreply@openai.com> * cargo fmt after the rename Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Codex <noreply@openai.com> Co-authored-by: Brandon Thomas <echelon@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #164.
The PDF text layer gave each glyph its text range by position. That worked only when a run had exactly one glyph per character. When a run had fewer or more glyphs than characters (for example a ligature such as "fl"), glyph 0 got the whole run's text and every other glyph got nothing. The ToUnicode CMap then mapped one glyph to a whole sentence and left codes like
<0002>with no mapping. poppler rejected the long entries, and text extraction came out garbled.The cluster data the issue asks for is already available:
GlyphRun.cellsholds, for each glyph, the paragraph character that heads its shaping cluster. The new helperglyph_text_rangesuses it:fandl), and every other glyph maps to its own character.text[range]cannot panic.Rendering does not change, because the text layer is invisible.
Test:
glyph_ranges_follow_shaping_clustersincrates/pdf/src/tests.rscovers an "fl" ligature, a two-glyph cluster, and a right-to-left run that starts mid-paragraph and uses multi-byte characters. With the old logic, the ligature case maps the whole word to glyph 0.