You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Morph: pick the next curve to split from a heap, not a full scan - #1782
What was wrong: contour alignment refine() rescanned every original curve for each extra subdivision; MAX_CURVES only limits the common-multiple choice, so large contours still got O(n x curves) work.
Changed: a BinaryHeap keyed on piece length (lowest index on ties, as before) picks the next curve, O(n log n). Same splits as before, so output is unchanged.
Blast radius: crates/geom morph only. No behavior change.
Checks run: cargo fmt --check, clippy -p deckcraft-geom --all-targets -D warnings, cargo test -p deckcraft-geom (new test refines 20k curves to 40k). Not run: workspace tests.
Summary by CodeRabbit
Improvements
Curve refinement now handles large sets more efficiently while producing the requested number of segments.
No actionable comments were generated in the recent review.
Walkthrough
Curve refinement now uses a max-heap to select the next curve to split instead of rescanning all curves after each split. The change adds a test that refines a contour with 20,000 curves to 40,000 curves.
Share orders piece lengths using f64::total_cmp. Each split selects the largest current piece, resolves ties by the lowest curve index, and reinserts the updated share. A test checks refinement of a 20,000-curve contour to 40,000 curves.
No actionable merge-blocking risk is established for this change.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: replacing full scans with a heap to select the next curve to split.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 1 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between aa13eeb and 253b9f8.
Files selected for processing: 1
crates/geom/src/morph.rs
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong: contour alignment refine() rescanned every original curve for each extra subdivision; MAX_CURVES only limits the common-multiple choice, so large contours still got O(n x curves) work.
Changed: a BinaryHeap keyed on piece length (lowest index on ties, as before) picks the next curve, O(n log n). Same splits as before, so output is unchanged.
Blast radius: crates/geom morph only. No behavior change.
Checks run: cargo fmt --check, clippy -p deckcraft-geom --all-targets -D warnings, cargo test -p deckcraft-geom (new test refines 20k curves to 40k). Not run: workspace tests.
Summary by CodeRabbit