Skip to content

Morph: pick the next curve to split from a heap, not a full scan - #1782

Merged
dylanmtaylor merged 1 commit into
mainfrom
fix/sec-morph-refine
Nov 4, 2026
Merged

dylanmtaylor merged 1 commit into
mainfrom
fix/sec-morph-refine

Conversation

@dylanmtaylor

@dylanmtaylor dylanmtaylor commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

What was wrong: contour alignment refine() rescanned every original curve for each extra subdivision; MAX_CURVES only limits the common-multiple choice, so large contours still got O(n x curves) work.

Changed: a BinaryHeap keyed on piece length (lowest index on ties, as before) picks the next curve, O(n log n). Same splits as before, so output is unchanged.

Blast radius: crates/geom morph only. No behavior change.

Checks run: cargo fmt --check, clippy -p deckcraft-geom --all-targets -D warnings, cargo test -p deckcraft-geom (new test refines 20k curves to 40k). Not run: workspace tests.

Summary by CodeRabbit

  • Improvements
    • Curve refinement now handles large sets more efficiently while producing the requested number of segments.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

Curve refinement now uses a max-heap to select the next curve to split instead of rescanning all curves after each split. The change adds a test that refines a contour with 20,000 curves to 40,000 curves.

Changes: Curve refinement

Layer / File(s) Summary
Heap-based curve splitting
crates/geom/src/morph.rs
Share orders piece lengths using f64::total_cmp. Each split selects the largest current piece, resolves ties by the lowest curve index, and reinserts the updated share. A test checks refinement of a 20,000-curve contour to 40,000 curves.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Suggested reviewers: alexanderalber

Merge Risk: Minimal · up to 253b9

No actionable merge-blocking risk is established for this change.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: replacing full scans with a heap to select the next curve to split.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 1 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between aa13eeb and 253b9f8.

Files selected for processing: 1
  • crates/geom/src/morph.rs

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.

@dylanmtaylor
dylanmtaylor merged commit a72a516 into main Nov 4, 2026
9 of 10 checks passed
@dylanmtaylor
dylanmtaylor deleted the fix/sec-morph-refine branch November 4, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant