Repository navigation
PPTX export: index animation targets, cache build roles, serialize run properties once per text run - #1788
Conversation
…, serialize run properties once per text run
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
What was wrong: the timing exporter searched the shape tree for each animation; by-paragraph builds recomputed paragraph roles per animation and expanded into an effect per paragraph with no overall limit; run_text serialized the same rPr again for every line break and piece of one text run.
Changed: shapes are indexed by id once per slide (first in document order, as find_shape returned); roles are cached per shape; a slide writes at most 100,000 effects (the rest are logged and left out; the existing 10,000-animation cap stays); run_text builds its rPr once and copies the string.
Blast radius: crates/pptx write/timing.rs and write/dml.rs. Behavior change: slides with more than 100,000 effects (only reachable from hostile input) are truncated. The paragraph() path for separate Break runs is unchanged (each carries its own props).
Checks run: cargo fmt --check, clippy -p deckcraft-pptx --all-targets -D warnings, cargo test -p deckcraft-pptx (all pass). Not run: new hostile-size tests, workspace tests.
Summary by CodeRabbit