Repository navigation
Outlines leave footer, date and slide-number placeholders out: export, RTF and the outline view - #1879
Merged
Conversation
…, RTF and the outline view An agent run exporting a deck as an outline got the footer text and the slide-number field (‹#›) as body lines under each title. PowerPoint's outline view shows title and body placeholders only, so the text outline, the RTF outline (Save As ▸ Outline/RTF) and the outline view now skip the footer-row placeholders as they already skipped the title. Split out of the frame export PR at review, which asked for all three together. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 58 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
aiongg
reviewed
Nov 5, 2026
aiongg
left a comment
Contributor
There was a problem hiding this comment.
AI-generated review (Opus). Not a maintainer decision.
No blocking problems found.
All three outline paths now skip footer, date and slide-number placeholders, the same way they already skipped the title.
- crates/format/src/lib.rs:699 and crates/format/src/rtf.rs:75 use the same condition, so the existing check that an RTF export reads back as the same text outline still holds.
- crates/ui-egui/src/sorter.rs:479 and crates/ui-egui/src/sorter.rs:516 apply the filter to both the outline block and its height estimate, so they stay in step.
- PhType::is_footer_kind also covers Header placeholders. Those appear only on notes and handout masters, so skipping them in slide outlines changes nothing.
Claims checked:
- verified: The text outline export skips footer, date and slide-number placeholders, as it already skipped the title. (crates/format/src/lib.rs:699 skips shapes where ph_type is_title() || is_footer_kind(). crates/model/src/lib.rs:160-161 defines is_footer_kind as Date | Footer | SlideNum | Header. Export "ou…
- verified: The RTF outline export (Save As Outline/RTF) skips the same placeholders. (crates/format/src/rtf.rs:75 uses the same is_title() || is_footer_kind() condition. Export "rtf" calls slides_to_rtf at crates/engine/src/cmd/file.rs:345.)
- verified: The outline view leaves footer, date and slide-number placeholders out. (crates/ui-egui/src/sorter.rs:516 filters the body editors and crates/ui-egui/src/sorter.rs:479 filters the height estimate, both with is_title() || is_footer_kind().)
- verified: Before this change, footer text and the slide-number field appeared as body lines. (Header-footer setup adds Date, Footer and SlideNum placeholders to slides (crates/engine/src/cmd/design/slide_setup.rs:129-172). The old filters skipped only is_title().)
Recommendation: merge after CI and checks pass.
Reviewed at ede154d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #1321 at review, which asked for all three together.
An agent run exporting a deck as an outline got the footer text and the slide-number field (‹#›) as body lines under each title. PowerPoint's outline view shows title and body placeholders only. The text outline export, the RTF outline (Save As ▸ Outline/RTF) and the outline view now skip footer, date and slide-number placeholders, as they already skipped the title.
Tests:
outline_export_skips_footer_date_and_slide_number(engine) checks both the .md and the .rtf export;the_outline_view_leaves_footer_date_and_slide_number_out(ui-egui) checks the outline view's block for a slide is unchanged when the footers are turned on.🤖 Generated with Claude Code