Skip to content

Outlines leave footer, date and slide-number placeholders out: export, RTF and the outline view - #1879

Merged
aiongg merged 1 commit into
storytold:mainfrom
zberry:outline-title-and-body
Nov 5, 2026
Merged

aiongg merged 1 commit into
storytold:mainfrom
zberry:outline-title-and-body

Conversation

@zberry

@zberry zberry commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Split out of #1321 at review, which asked for all three together.

An agent run exporting a deck as an outline got the footer text and the slide-number field (‹#›) as body lines under each title. PowerPoint's outline view shows title and body placeholders only. The text outline export, the RTF outline (Save As ▸ Outline/RTF) and the outline view now skip footer, date and slide-number placeholders, as they already skipped the title.

Tests: outline_export_skips_footer_date_and_slide_number (engine) checks both the .md and the .rtf export; the_outline_view_leaves_footer_date_and_slide_number_out (ui-egui) checks the outline view's block for a slide is unchanged when the footers are turned on.

🤖 Generated with Claude Code

…, RTF and the outline view

An agent run exporting a deck as an outline got the footer text and the
slide-number field (‹#›) as body lines under each title. PowerPoint's
outline view shows title and body placeholders only, so the text outline,
the RTF outline (Save As ▸ Outline/RTF) and the outline view now skip the
footer-row placeholders as they already skipped the title. Split out of the
frame export PR at review, which asked for all three together.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 58 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 8 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 6431460 and ede154d.

Files selected for processing: 5

  • crates/engine/src/tests.rs
  • crates/format/src/lib.rs
  • crates/format/src/rtf.rs
  • crates/ui-egui/src/sorter.rs
  • crates/ui-egui/src/sorter/ui_tests.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@aiongg aiongg added the bugfix Fixes something that is broken: wrong result, crash, data loss label Nov 5, 2026

@aiongg aiongg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI-generated review (Opus). Not a maintainer decision.

No blocking problems found.

All three outline paths now skip footer, date and slide-number placeholders, the same way they already skipped the title.

  • crates/format/src/lib.rs:699 and crates/format/src/rtf.rs:75 use the same condition, so the existing check that an RTF export reads back as the same text outline still holds.
  • crates/ui-egui/src/sorter.rs:479 and crates/ui-egui/src/sorter.rs:516 apply the filter to both the outline block and its height estimate, so they stay in step.
  • PhType::is_footer_kind also covers Header placeholders. Those appear only on notes and handout masters, so skipping them in slide outlines changes nothing.

Claims checked:

  • verified: The text outline export skips footer, date and slide-number placeholders, as it already skipped the title. (crates/format/src/lib.rs:699 skips shapes where ph_type is_title() || is_footer_kind(). crates/model/src/lib.rs:160-161 defines is_footer_kind as Date | Footer | SlideNum | Header. Export "ou…
  • verified: The RTF outline export (Save As Outline/RTF) skips the same placeholders. (crates/format/src/rtf.rs:75 uses the same is_title() || is_footer_kind() condition. Export "rtf" calls slides_to_rtf at crates/engine/src/cmd/file.rs:345.)
  • verified: The outline view leaves footer, date and slide-number placeholders out. (crates/ui-egui/src/sorter.rs:516 filters the body editors and crates/ui-egui/src/sorter.rs:479 filters the height estimate, both with is_title() || is_footer_kind().)
  • verified: Before this change, footer text and the slide-number field appeared as body lines. (Header-footer setup adds Date, Footer and SlideNum placeholders to slides (crates/engine/src/cmd/design/slide_setup.rs:129-172). The old filters skipped only is_title().)

Recommendation: merge after CI and checks pass.

Reviewed at ede154d.

@aiongg aiongg self-assigned this Nov 5, 2026
@aiongg
aiongg merged commit acd19ff into storytold:main Nov 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixes something that is broken: wrong result, crash, data loss

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants