Skip to content

Updates: take craft-update from craft-libs main at 6e03f65bf - #2038

Closed
dotCooCoo wants to merge 2 commits into
storytold:mainfrom
dotCooCoo:chore/craft-update-6e03f65
Closed

dotCooCoo wants to merge 2 commits into
storytold:mainfrom
dotCooCoo:chore/craft-update-6e03f65

Conversation

@dotCooCoo

@dotCooCoo dotCooCoo commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

This moves craft-update, craft-media, craft-pdf, craft-ui and krilla from storytold/craft-libs at 1b34eba41 to 6e03f65bf, which is craft-libs main with #763 and #803 merged. Cargo.lock and the expected source in xtask/src/pdf_deps.rs move with it. No other crate moves.

What users get from craft-update:

  • An unsigned Windows copy gets Download instead of Update and Restart, and a Windows copy that cannot install is detected before the download starts.
  • A failure recorded before the running program started is not reported, and a Cargo build with a separate build directory counts as a development build.
  • A copy that cannot be replaced (a macOS bundle, an AppImage or a standalone program whose files the update cannot write) gets Download, and so does a standalone macOS program whose release has no macOS .tar.gz.
  • A slow macOS signature check is not reported as a bad signature, and an install stops when the check for a running app gets no answer.
  • A failed self-update keeps its download for the next try, and a macOS install that stopped partway no longer blocks the next one.
  • A release folder that cannot be read stops a standalone update.
  • A failed check for a running attach is reported on macOS.

Testing: cargo fmt --all -- --check and cargo check --workspace --tests --locked pass on Windows 11 x86-64 with this head. The other checks run in this pull request's CI.

cargo xtask ci passed in this pull request's CI run on ab13d62526: https://github.com/storytold/deckcraft/actions/runs/43072321558/job/130703286006

  • cargo xtask ci passes

Summary by CodeRabbit

  • Chores
    • Updated the shared components used by media, PDF, update, and interface features to a newer revision.
    • Updated dependency validation to check against the same revision.

Moves craft-update, craft-media, craft-pdf, craft-ui and krilla to craft-libs 6e03f65bf, with Cargo.lock and the expected source in xtask/src/pdf_deps.rs.
@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The craft-libs revision changes in four workspace dependencies, the krilla patch, and the xtask PDF dependency check. Other listed dependency settings remain unchanged.

Changes: craft-libs revision alignment

Layer / File(s) Summary
Update dependency pins and revision check
Cargo.toml, xtask/src/pdf_deps.rs
The four craft-libs dependencies, the krilla patch, and SHARED_REV now use revision 6e03f65bf45181db77ba6229716e6624db9eb25b. Package versions and other listed dependency settings remain unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: dylanmtaylor

Merge Risk: Minimal · up to 31596

This PR aligns the craft-libs dependency pins and the PDF dependency check on one revision. No actionable merge-blocking risk was found. The remaining checks run in CI.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title accurately identifies the craft-update dependency revision change. It omits the other four updated crates, but it remains specific and related to a real part of the changeset.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 121c59d and 3159640.

Files ignored due to path filters: 1

  • Cargo.lock is excluded by !**/*.lock
Files selected for processing: 2

  • Cargo.toml
  • xtask/src/pdf_deps.rs

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

@autocraft-bot autocraft-bot Bot added bugfix Fixes something that is broken: wrong result, crash, data loss needs decision Needs a product or scope decision by a maintainer labels Nov 11, 2026

@FredApps FredApps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed current head ab13d62526603e75d4777449573b1aeaec4a71c1. The current PR diff against its base is only the os_pipe lockfile dependency resolution from windows-sys 0.61.2 to 0.45.0; the craft-libs bump described in the body is already in the base. The emitted CI gate and font-pin checks pass. Please refresh the description to match the remaining change. No independent build or tests were run for this review, and this is not a fresh approval of the broader upstream dependency changes.

@dotCooCoo

Copy link
Copy Markdown
Contributor Author

Closing: the craft-libs move landed in main with #2041, and main's gate passes with its current os_pipe lock entry, so the remaining Cargo.lock change is not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixes something that is broken: wrong result, crash, data loss needs decision Needs a product or scope decision by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants