Repository navigation
Conversation
Moves craft-update, craft-media, craft-pdf, craft-ui and krilla to craft-libs 6e03f65bf, with Cargo.lock and the expected source in xtask/src/pdf_deps.rs.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
FredApps
left a comment
There was a problem hiding this comment.
Reviewed current head ab13d62526603e75d4777449573b1aeaec4a71c1. The current PR diff against its base is only the os_pipe lockfile dependency resolution from windows-sys 0.61.2 to 0.45.0; the craft-libs bump described in the body is already in the base. The emitted CI gate and font-pin checks pass. Please refresh the description to match the remaining change. No independent build or tests were run for this review, and this is not a fresh approval of the broader upstream dependency changes.
|
Closing: the craft-libs move landed in main with #2041, and main's gate passes with its current os_pipe lock entry, so the remaining Cargo.lock change is not needed. |
This moves craft-update, craft-media, craft-pdf, craft-ui and krilla from storytold/craft-libs at 1b34eba41 to 6e03f65bf, which is craft-libs main with #763 and #803 merged. Cargo.lock and the expected source in xtask/src/pdf_deps.rs move with it. No other crate moves.
What users get from craft-update:
.tar.gz.Testing:
cargo fmt --all -- --checkandcargo check --workspace --tests --lockedpass on Windows 11 x86-64 with this head. The other checks run in this pull request's CI.cargo xtask cipassed in this pull request's CI run onab13d62526: https://github.com/storytold/deckcraft/actions/runs/43072321558/job/130703286006cargo xtask cipassesSummary by CodeRabbit