Repository navigation
PPTX: .potx and .ppsx declare a template and slide show main part (#210) - #212
Merged
h-a-n-a-s-h-i merged 1 commit intoOct 14, 2026
Conversation
…orytold#210) Saving with a .potx or .ppsx name wrote a byte-identical .pptx: the main part was always presentationml.presentation.main+xml, because format_for_path folded all three extensions into "pptx". It now keeps potx/ppsx, and deckcraft_pptx::export_as picks the template or slideshow content type. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 of 3 tasks
Member
|
Thank you for this contribution, @justinjohn0306! It has landed on If you haven't already, please come join us on Discord: https://discord.gg/artcraft |
sirmmo
added a commit
to sirmmo/deckcraft
that referenced
this pull request
Oct 14, 2026
Brings in 669 upstream commits. Upstream's .potx/.ppsx content types (storytold#212) now go through PptxKind (export_as takes a kind; .pptm/.potm/.ppsm too); kept add-in parts (storytold#531) and the VBA project are both written. Office.js reports 3D models as model3D; quick-xml 0.41's normalized_value. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
anishguduru
pushed a commit
to anishguduru/deckcraft
that referenced
this pull request
Oct 16, 2026
…orytold#212) * M3: unify toolbar and menu theme preferences Co-authored-by: Codex <noreply@openai.com> * M3: use the current egui style API in theme regression Co-authored-by: Codex <noreply@openai.com> --------- Co-authored-by: Codex <noreply@openai.com> Co-authored-by: Brandon Thomas <echelon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #210.
Cause:
format_for_pathfolded.pptx,.potxand.ppsxinto"pptx", and the writer only hadCT_PRES, so all three outputs were byte-identical.Fix
format_for_pathreturnspotx/ppsxfor those extensions;save_bytespasses the format on.deckcraft_pptx::export_as(p, ext):potx→presentationml.template.main+xml,ppsx→presentationml.slideshow.main+xml, otherwise the presentation type.export(p)is unchanged for existing callers.This covers File ▸ Save / Save As with a
.potx/.ppsxname,file.export, anddeckcraft-cli convert.Verified
converttodeck.pptx/deck.potx/deck.ppsxnow givespresentation,templateandslideshowmain content types..potxopened as a template becomes an untitled presentation ("Northern Lights", no path).templates_and_slide_shows_declare_their_own_main_content_typetest (each one also reads back);cargo test -p deckcraft-pptx -p deckcraft-engine;cargo clippy --workspace --all-targets -D warnings;cargo fmt --check.🤖 Generated with Claude Code