Repository navigation
docs: prefer shared Craft libraries for reusable features - #2178
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
There was a problem hiding this comment.
AI-generated review (Opus). Not a maintainer decision.
No blocking problems found.
Claims checked:
- verified: The change only appends a shared-library section to AGENTS.md and keeps all existing content, including the generated house-rule blocks. (The diff has a single hunk after AGENTS.md:241 that adds four lines (a blank line, the heading, a blank line and the paragraph) and removes nothing. The house-ru…
- verified: The guidance says to check shared libraries first for formats, codecs, protocols and reusable UI, while keeping app policy and model mapping local and preserving behaviour, security limits, attribution and tests. (withheld)
Reviewed at 9b50c07.
Recommendation: merge, after a maintainer's decision.
FredApps
left a comment
There was a problem hiding this comment.
Reviewed 9b50c07. The full diff only appends the Shared libraries section to AGENTS.md; existing repository instructions and generated house-rule blocks are unchanged. Checking craft-libs and open PRs before implementing reusable code aligns with #778, while explicitly retaining app policy/model mapping, security/resource limits, attribution and regression coverage. I checked the surrounding repository instructions and shared guidance; this does not relax clean-room, layering, dependency licensing or validation requirements. No blocking documentation finding.
Validation: current-head hosted CI gate, house-rules check and Sonar checks passed. No local build or runtime tests run for this documentation-only change.
The existing permission to copy from sibling apps is not a requirement to duplicate shared libraries; the new shared-library-first direction and preserved app-specific boundary are compatible.



Summary
Validation
Summary by CodeRabbit