Repository navigation
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
There was a problem hiding this comment.
AI-generated review (Claude Opus 5.5). Not a maintainer decision.
No blocking problems found (not certain).
A complete from/to range in show.setup now clears a previously selected custom show, so playback uses the new range; a custom show named in the same request still wins.
- crates/engine/src/cmd/review.rs:608-611: clearing custom_show only when both endpoints are present keeps one-endpoint requests unchanged, matching the description.
- crates/engine/src/cmd/review.rs:612: the 'all' branch resets the range but leaves custom_show in place; if selecting all slides should also replace an active custom show, it needs the same clear.
- crates/engine/src/cmd/review.rs:941-959: the test checks actual playback order for the precedence case, the single-endpoint cases and the replacement case.
Claims checked:
- verified: A complete slide range now clears the previous custom show, so playback uses the new range. (crates/engine/src/cmd/review.rs:608-611 sets sh.range and then sh.custom_show = None in the (Some(a), Some(b)) arm; the test at crates/engine/src/cmd/review.rs:956-958 asserts order [1, 2] and custom_show…
- unverified: A named custom show in the same request still takes precedence over the range. (The code that applies the 'custom' parameter in setup is not in the diff; the test at crates/engine/src/cmd/review.rs:949-950 asserts order [0, 1] for {from, to, custom}.)
- verified: Incomplete ranges (only one endpoint) keep their existing behaviour. (crates/engine/src/cmd/review.rs:613 keeps the
_ => {}arm unchanged; the test at crates/engine/src/cmd/review.rs:951-954 checks {from} and {to} alone keep the custom show.)
Reviewed at db439da.
Recommendation: merge, after a maintainer's decision.
DeckCraft plays the newly selected slide range after a custom show was selected earlier.
The setup command stored the new range but left the old custom-show name in place. Playback gives a custom show precedence, so it ignored the range. A complete range now clears the previous custom show. A named custom show in the same request still takes precedence, and incomplete ranges keep their existing behavior.
setting_a_show_range_replaces_an_active_custom_showchecks the actual playback order and both precedence cases. An isolated check using the exact setup code and playback-order helper reproduced playback of the old selection onmain; all three focused tests passed with the fix. Rustfmt passed. I did not run the full workspace suite locally.Summary by CodeRabbit