Skip to content

Format: make PPTX the default presentation file format - #388

Open
GhostMitra wants to merge 1 commit into
storytold:mainfrom
GhostMitra:feat/default-format-pptx
Open

GhostMitra wants to merge 1 commit into
storytold:mainfrom
GhostMitra:feat/default-format-pptx

Conversation

@GhostMitra

Copy link
Copy Markdown
Contributor

Summary

Makes .pptx the default presentation file format across DeckCraft instead of .deckcraft:

  1. Engine Commands:
    • save_bytes defaults fallback serialization to deckcraft_pptx::export.
    • save_bytes_cmd defaults format parameter to "pptx".
    • format_for_path defaults unspecified extensions and unknown paths to "pptx".
    • file.save and file.saveBytes specs list pptx|deckcraft.
  2. UI & Dialogs:
    • SlideApp::save_as_dialog defaults extension to "pptx" (unless "deckcraft" is explicitly passed).
    • SlideApp::save() and app.saveAsDialog trigger save_as_dialog("pptx").
    • Native file picker filters in apps/deckcraft/src/main.rs prioritize pptx in "Presentations" and list "PowerPoint" ahead of "DeckCraft".
  3. Web Runner:
    • PRESENTATION_EXTS in deckcraft-web lists pptx first.
    • Fallback download name in deckcraft-web defaults to "presentation.pptx".
  4. Tests & Attribution:
    • Added unit test default_save_format_is_pptx and verified roundtrip save/reopen in crates/engine/src/tests.rs.
    • Added contributor attribution for @GhostMitra in contributors/people.toml.

Verification

  • cargo fmt --check passed.
  • cargo test --workspace passed (all workspace tests passed).
  • cargo clippy --workspace -- -D warnings passed (0 warnings).
  • cargo run -p xtask -- wasm passed (all 23 crates checked cleanly for wasm32-unknown-unknown).

anishguduru pushed a commit to anishguduru/deckcraft that referenced this pull request Oct 16, 2026
…told#333) (storytold#388)

FDF export dropped /IRT, so a note's replies and its review-status reply
imported as unrelated comments. Each comment is now an indirect object of
the FDF (with a cross-reference table), and a reply's /IRT points at its
parent's object there, as ISO 32000-2 §12.7.8.3.1 allows. Import maps the
FDF objects to the placed comments and links replies in a second pass,
falling back to a parent of the same /NM already in the document.

FDFs with direct comment dictionaries still import. Self-references,
missing parents and cycles are ignored without panicking.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Brandon Thomas <echelon@gmail.com>

@FredApps FredApps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReviewerA — source-read COMMENT (not an approval)

I read the head of the diff: PPTX becomes the default presentation file format. The extension lists put pptx first, the fallback name becomes presentation.pptx, and the file dialogs list Presentations with pptx first. A default format is a product decision, not a bug fix: the native .deckcraft format keeps everything (the application's own features) and PPTX loses what PowerPoint cannot hold, so a user who saves as the default can lose data without being told. PowerPoint itself defaults to PPTX, and so does Keynote's export, but the maintainers should decide, and the save path should warn when features would be lost. Existing tests that assume the old order or name must change; I did not see them. I have not run it, and no exact-head CI result exists for this head. Nothing was run.

I ran nothing and have no exact-head CI result for this PR, so this is not an approval. Where a diff was long I read its code hunks rather than every generated or documentation line.

Status: waiting_author.

@aiongg aiongg added bugfix Fixes something that is broken: wrong result, crash, data loss needs decision Needs a product or scope decision by a maintainer labels Nov 4, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixes something that is broken: wrong result, crash, data loss needs decision Needs a product or scope decision by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants