Repository navigation
Format: make PPTX the default presentation file format - #388
GhostMitra wants to merge 1 commit into
Conversation
…told#333) (storytold#388) FDF export dropped /IRT, so a note's replies and its review-status reply imported as unrelated comments. Each comment is now an indirect object of the FDF (with a cross-reference table), and a reply's /IRT points at its parent's object there, as ISO 32000-2 §12.7.8.3.1 allows. Import maps the FDF objects to the placed comments and links replies in a second pass, falling back to a parent of the same /NM already in the document. FDFs with direct comment dictionaries still import. Self-references, missing parents and cycles are ignored without panicking. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Brandon Thomas <echelon@gmail.com>
e9deb6b to
c5dca31
Compare
FredApps
left a comment
There was a problem hiding this comment.
ReviewerA — source-read COMMENT (not an approval)
I read the head of the diff: PPTX becomes the default presentation file format. The extension lists put pptx first, the fallback name becomes presentation.pptx, and the file dialogs list Presentations with pptx first. A default format is a product decision, not a bug fix: the native .deckcraft format keeps everything (the application's own features) and PPTX loses what PowerPoint cannot hold, so a user who saves as the default can lose data without being told. PowerPoint itself defaults to PPTX, and so does Keynote's export, but the maintainers should decide, and the save path should warn when features would be lost. Existing tests that assume the old order or name must change; I did not see them. I have not run it, and no exact-head CI result exists for this head. Nothing was run.
I ran nothing and have no exact-head CI result for this PR, so this is not an approval. Where a diff was long I read its code hunks rather than every generated or documentation line.
Status: waiting_author.
Summary
Makes
.pptxthe default presentation file format across DeckCraft instead of.deckcraft:save_bytesdefaults fallback serialization todeckcraft_pptx::export.save_bytes_cmddefaults format parameter to"pptx".format_for_pathdefaults unspecified extensions and unknown paths to"pptx".file.saveandfile.saveBytesspecs listpptx|deckcraft.SlideApp::save_as_dialogdefaults extension to"pptx"(unless"deckcraft"is explicitly passed).SlideApp::save()andapp.saveAsDialogtriggersave_as_dialog("pptx").apps/deckcraft/src/main.rsprioritizepptxin "Presentations" and list "PowerPoint" ahead of "DeckCraft".PRESENTATION_EXTSindeckcraft-weblistspptxfirst.deckcraft-webdefaults to"presentation.pptx".default_save_format_is_pptxand verified roundtrip save/reopen incrates/engine/src/tests.rs.contributors/people.toml.Verification
cargo fmt --checkpassed.cargo test --workspacepassed (all workspace tests passed).cargo clippy --workspace -- -D warningspassed (0 warnings).cargo run -p xtask -- wasmpassed (all 23 crates checked cleanly for wasm32-unknown-unknown).