Repository navigation
Conversation
…es (storytold#630) Release builds said "Text recognition isn't installed: its models are missing" because no packaging script or release job fetched the OCR models: only `cargo xtask models` does, into the source tree. - packaging/env.sh gains stage_models DEST, which runs `cargo xtask models DEST` (every ATTRIBUTION.toml kind = "model" file, SHA-256 verified, with its licence text). No model file is named, so the models PRs storytold#433/storytold#572 add ship without packaging changes. - `cargo xtask models` also writes ATTRIBUTION.txt crediting each model (CC-BY-SA-4.0 requires attribution when redistributed). - macOS: PdfCraft.app/Contents/Resources/models, before signing. - Windows: models\ beside pdfcraft.exe in the MSI (WiX v5 <Files> harvest) and the portable zip; test-msi.ps1 checks the folder. - Linux deb/rpm/tar.gz/AppImage, Flatpak bundle and FreeBSD tarball: share/pdfcraft/models beside bin/. Models::search_dirs now also looks in <exe dir>/../share/pdfcraft/models (Models::dirs_beside_exe); a test builds every package layout on disk and finds the models in each. release.yml and freebsd.yml check the packages contain them. - The missing-models messages no longer tell end users to run cargo, and the 11 catalogs that keyed an old PRINTCRAFT_MODELS wording (or the previous one) now key the current English text; ATTRIBUTION hashes updated. A test checks the translations match. The web (wasm) build, which the issue reports, still has no models; this is the desktop half only. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
When two displays are connected the show goes borderless-fullscreen on the first non-primary and presenter view fills the primary. One display stays full screen on the current one. Co-authored-by: Cursor <cursoragent@cursor.com>
603119e to
d0081ca
Compare
|
Tested on a Mac with three displays. Before testing, I rebased this branch locally onto current Setup: MacBook (built-in Retina, 1512×982 pt at 2×) on the left; a Dell U2417H set as the macOS main display (menu bar) in the middle; a second U2417H on the right.
The main point: which display is which. The PR treats the primary display as the presenter's screen. On a Mac, the primary display is just the one with the menu bar, and with an external monitor that's often the external one. Here, that put presenter view on the big monitor and the slides on the laptop, the opposite of what a presenter wants: the show on the main or projector display, and presenter view on the laptop's own screen. Suggestion: prefer the built-in display for presenter view when there is one, and show the slides on the primary display if it's external, otherwise on the first external one. Fall back to the current rule (presenter on primary) when no display is built in. On macOS, |
|
Comparison of the four open PRs that change where the slide show and Presenter View go on one or two displays: this one, #1156, #1184 and #1225 (#709 is the closed earlier version of #1156). Nothing here picks one.
Every pair conflicts with every other, mostly in PowerPoint check (real PowerPoint 16.0.20527 through COM, one temporary two-slide presentation, Not checked: PowerPoint with two displays (this machine has one, so Slide Show Monitor, Swap Displays and where PowerPoint places each window were not tested); any of the four PRs built or run; behaviour on Wayland or macOS (the author of a comment here tested #433 on a Mac with three displays after a local rebase). The table comes from the diffs and PR texts at the heads fetched on 27 Oct. |
FredApps
left a comment
There was a problem hiding this comment.
ReviewerA — source-read COMMENT (not an approval)
I read the head of the diff: Present puts the slide show on the other display. The ROADMAP table is rewritten by hand (feature breadth 80% weighted over 191 features with P0 92%, P1 75%, P2 36%; menu bar coverage 59%; component scores for transitions, animations, slide show and review), which are numbers that cargo xtask parity and the project's tooling produce and are better left to it. The feature (choose a screen for the show) is PowerPoint's Set Up Slide Show › Show on. It overlaps deckcraft#1156 and #1184 (counting displays, Presenter View), all three adding display logic, so the maintainers must order them. I did not read the display code. I have not run it, and no exact-head CI result exists for this head. Nothing was run.
I ran nothing and have no exact-head CI result for this PR, so this is not an approval. Where a diff was long I read its code hunks rather than every generated or documentation line.
Status: waiting_author.
Summary
Test plan
cargo test -p deckcraft-ui-egui --lib show::testsMade with Cursor