Skip to content

UI: notes, alt text and rename drafts no longer carry over to another document (#413) - #450

Merged
h-a-n-a-s-h-i merged 1 commit into
storytold:mainfrom
MarekSpodBiedry:issue-413
Oct 14, 2026
Merged

h-a-n-a-s-h-i merged 1 commit into
storytold:mainfrom
MarekSpodBiedry:issue-413

Conversation

@MarekSpodBiedry

Copy link
Copy Markdown
Contributor

Fixes #413.

Three text drafts were cached by slide index or shape id alone, so they could show up in, and be written to, the wrong place:

  • Notes Page (sorter.rs): the box kept its text under ("notespage", slide_index) and committed it on focus loss. The same index in another document, a slide reorder or an undo of the notes brought back the old text. The draft is now keyed by document uid and slide index, and it remembers the notes it started from. When the stored notes change underneath it (other document, reorder, undo), the stored notes are shown again instead of the stale draft.
  • Selection pane rename (selpane.rs): State kept renaming under a bare shape id, so a pending rename could be committed to a shape with the same id in another document. State now records which document (uid) it belongs to. show calls State::bind(uid) first, and on a document switch the rename, folds, anchor and drag are reset.
  • Format Shape > Alt Text (panes.rs): this field had the same problem. Its draft was keyed by shape id only and never cleared. It now uses the same document-uid key and the same resync as the Notes Page.

The resync logic is one small helper, widgets::text_draft, used by both text fields.

Tests:

  • selpane::tests::switching_document_drops_a_pending_rename: the same document keeps the draft, another document drops it (and the folds).
  • widgets::tests::text_draft_keeps_typing_while_the_stored_text_is_unchanged / text_draft_drops_a_stale_draft_when_the_stored_text_changes.

The Outline pane drafts were already safe because they are cleared as soon as the field loses focus, so I left them as they are.

@MarekSpodBiedry
MarekSpodBiedry marked this pull request as ready for review October 13, 2026 15:46
@h-a-n-a-s-h-i
h-a-n-a-s-h-i merged commit 194e7fc into storytold:main Oct 14, 2026
1 check passed
@echelon

echelon commented Oct 14, 2026

Copy link
Copy Markdown
Member

Thank you for this contribution, @MarekSpodBiedry! It has landed on main and will ship in the next DeckCraft release.

If you haven't already, please come join us on Discord: https://discord.gg/artcraft

anishguduru pushed a commit to anishguduru/deckcraft that referenced this pull request Oct 16, 2026
* D5: README for cos and engine, and an honest cos status line

Thirteen crates have no README, although the session protocol tells every session to read the README of the crate it is touching. These are the two biggest: cos is where every hostile file lands first, and engine is the whole API surface a frontend gets.

Each states its layer and the rules that bind it, sketches the API against the real signatures, and ends with what is deliberately not done. The cos README spells out the clone-is-a-snapshot property and why both writers return bytes rather than taking a sink; the engine README spells out the four-step editing model that makes what you see what Save writes.

Also corrects the module doc on cos/src/lib.rs, which still said encryption and object-stream output for full saves were not done. Both shipped: security.rs handles R2-R6 with crypt filters and /EFF, and SaveOptions::object_streams defaults to true.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* Preserve alternate appearances and indirect push-button values

Keep rollover, down and custom appearance entries when normal appearances are regenerated, without modifying shared dictionaries. Resolve indirect button caption and layout values. Cover full and incremental saved output, and wait for raster readiness in the existing Linux scroll test.

Co-authored-by: Codex <codex@openai.com>

* M7: select and edit grouped Form XObject figures

Co-Authored-By: Codex <noreply@openai.com>

* M14: let neutral Windows locales fall through to display language

Co-authored-by: Codex <codex@openai.com>

* pdfcraft-cli --help lists `mcp` only when the build has it

Follow-up to storytold#540: a build without the `mcp` feature (`--no-default-features`) still listed
`pdfcraft-cli mcp` in its usage, and `pdfcraft-cli mcp` then said "unknown command".

USAGE is now put together with `concat!`, and its `mcp` lines come from a macro that is empty
without the feature. In such a build `pdfcraft-cli mcp` says the MCP server was left out instead
of calling it an unknown command.

- tests/help.rs: usage_lists_mcp_only_when_built_with_it (runs in both feature sets) and
  mcp_without_the_feature_says_it_was_left_out (without the feature)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* engine README: the execution plan is local-only, so don't link a path that doesn't exist

---------

Co-authored-by: Tanish Manku <tmanku.dev@gmail.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: sanyamsingh001 <314051937+sanyamsingh001@users.noreply.github.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Streetblock <github@streetblock.de>
Co-authored-by: lloyd <lloyd@stackworx.io>
Co-authored-by: Brandon Thomas <echelon@gmail.com>
anishguduru pushed a commit to anishguduru/deckcraft that referenced this pull request Oct 16, 2026
…orytold#605)

Four squash merges in a row (storytold#450, storytold#414, storytold#451, storytold#351) each re-added the
same 206-line block from storytold#417 to crates/forms/src/tests.rs, so the crate's
tests no longer compiled (E0428: three test functions defined five times)
and main went red on every platform. Keep the first copy. The same merges
repeated one ROADMAP log line four times; keep one.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Audit] Notes and selection-pane rename drafts are not scoped to the owning document

3 participants