Repository navigation
UI: open presentations in the background with a progress window (#350) - #488
Merged
Merged
Conversation
…ytold#350) Opening from the file picker or the Backstage recent list read and parsed the file on the UI thread, so a large PPTX froze the window. The read now runs on a thread (engine: read_presentation_file / add_presentation_file), and a modal shows the file name, elapsed time and Cancel; Escape cancels too. A cancelled read is dropped when it finishes. Scripted opens (control, MCP, CLI) and the web build stay synchronous. Co-authored-by: Cursor <cursoragent@cursor.com>
h-a-n-a-s-h-i
pushed a commit
that referenced
this pull request
Oct 14, 2026
The progress window's result was added with add_presentation_file, straight
into the session: not journaled and outside the command panic guard that
file.open runs under. The host now hands the loaded file to
Session::stage_loaded and runs the new internal command file.adopt {path,
token}, which shares file.open's tail (repaired-copy handling, damaged-media
report) and so is journaled and guarded. Without the staged copy (a replayed
journal, a stale token) file.adopt reads path like file.open. Reading still
happens on the background thread.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
h-a-n-a-s-h-i
pushed a commit
that referenced
this pull request
Oct 14, 2026
… screen Main (#346) shows why a file couldn't be opened as a notice over the start screen; #488's background open put the error in the status bar instead, which broke a_file_that_cant_be_opened_says_why. The background open now reports through the same notice, and the test waits for the background read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
h-a-n-a-s-h-i
pushed a commit
that referenced
this pull request
Oct 14, 2026
Member
|
Thank you for this contribution, @NikitkaRa! It has landed on If you haven't already, please come join us on Discord: https://discord.gg/artcraft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #350.
Summary
file.openis split intoread_presentation_file(path) -> LoadedFile, which needs no session, andadd_presentation_file(session, LoadedFile).file.openbehaves exactly as before. Control-channel, MCP, CLI and command-line opens stay synchronous.Test plan
opening::tests:backstage_tests::open_lists_recent_files_and_opens_one: now waits for the background read.cargo xtask ci: fmt, clippy-D warnings, test, assets, layers, wasm all pass.No parity-checklist row changes: this is a responsiveness feature with no checklist row.