Skip to content

UI: add Save As to the title bar - #497

Open
NikitkaRa wants to merge 1 commit into
storytold:mainfrom
NikitkaRa:cursor/save-as-ui-b770
Open

NikitkaRa wants to merge 1 commit into
storytold:mainfrom
NikitkaRa:cursor/save-as-ui-b770

Conversation

@NikitkaRa

Copy link
Copy Markdown
Contributor

Summary

  • The title bar has a Save As… button beside Save. ⇧⌘S (Ctrl+Shift+S on Windows and Linux) runs the same command, and the command palette lists that shortcut.
  • It writes a new file in the presentation's own format (PowerPoint when the deck has never been saved). The file already on disk is left byte for byte as it was, and the window then shows the new file.
  • Cancelling the dialog leaves the presentation and its file unchanged. On the web, Save As downloads a copy and the open presentation stays as it was.
  • File › Save As still chooses the type (PowerPoint, DeckCraft, PDF, outline, pictures). Export's Save As button is unchanged.

Test plan

  • Open a saved .pptx, edit it, and click Save As… on the title bar. The copy has the edits, the original file is unchanged, and the window shows the new file.
  • Press ⇧⌘S (Ctrl+Shift+S) on a .deckcraft file and confirm the suggested name keeps that extension.
  • Cancel the dialog and confirm the presentation stays dirty and its file is unchanged.
  • With nothing open, Save As… is present and does not ask for a file.
  • On the web, Save As downloads a copy and the open presentation keeps its path.
  • File › Export › Change File Type › Save As still writes the chosen type.

Closes #363

@NikitkaRa NikitkaRa mentioned this pull request Oct 13, 2026
2 tasks done
The File tab already had a Save As page, but the title bar did not, and
the shortcut was not shown. Save As… (⇧⌘S / Ctrl+Shift+S) writes a new
file in the presentation's own format and leaves the file already on
disk unchanged.

Closes storytold#363

Co-authored-by: Cursor <cursoragent@cursor.com>

@FredApps FredApps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReviewerA — source-read COMMENT (not an approval)

I read the head of the diff: Save As is added to the title bar and bound to Cmd+Shift+S (Ctrl+Shift+S): it writes a copy in the presentation's own format and leaves the file already on disk alone. The test writes a new file in a temporary folder and checks the original file is byte for byte unchanged. PowerPoint's Save As leaves the old file and switches the document to the new one, so after Save As the open document should point to the new path, which the ROADMAP row (a copy) may or may not describe. The temporary folder is named with the process id, which is unique enough for a test but is cleaned up only if the test passes. I have not run it, and no exact-head CI result exists for this head. Nothing was run.

I ran nothing and have no exact-head CI result for this PR, so this is not an approval. Where a diff was long I read its code hunks rather than every generated or documentation line.

Status: waiting_author.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No "Save as" option in the UI

2 participants