Repository navigation
Conversation
The File tab already had a Save As page, but the title bar did not, and the shortcut was not shown. Save As… (⇧⌘S / Ctrl+Shift+S) writes a new file in the presentation's own format and leaves the file already on disk unchanged. Closes storytold#363 Co-authored-by: Cursor <cursoragent@cursor.com>
be5377f to
f5cc553
Compare
FredApps
left a comment
There was a problem hiding this comment.
ReviewerA — source-read COMMENT (not an approval)
I read the head of the diff: Save As is added to the title bar and bound to Cmd+Shift+S (Ctrl+Shift+S): it writes a copy in the presentation's own format and leaves the file already on disk alone. The test writes a new file in a temporary folder and checks the original file is byte for byte unchanged. PowerPoint's Save As leaves the old file and switches the document to the new one, so after Save As the open document should point to the new path, which the ROADMAP row (a copy) may or may not describe. The temporary folder is named with the process id, which is unique enough for a test but is cleaned up only if the test passes. I have not run it, and no exact-head CI result exists for this head. Nothing was run.
I ran nothing and have no exact-head CI result for this PR, so this is not an approval. Where a diff was long I read its code hunks rather than every generated or documentation line.
Status: waiting_author.
Summary
Test plan
.pptx, edit it, and click Save As… on the title bar. The copy has the edits, the original file is unchanged, and the window shows the new file..deckcraftfile and confirm the suggested name keeps that extension.Closes #363