Skip to content

UI: Korean for the application shell - #548

Open
NikitkaRa wants to merge 1 commit into
storytold:mainfrom
NikitkaRa:cursor/ko-shell-7e0f
Open

NikitkaRa wants to merge 1 commit into
storytold:mainfrom
NikitkaRa:cursor/ko-shell-7e0f

Conversation

@NikitkaRa

Copy link
Copy Markdown
Contributor

Summary

  • Preferences offers System, English and 한국어. The choice is saved in the UI state and can also be set with app.language (system, en or ko).
  • System follows a ko or ko-KR locale. On the web build, System stays English until the user picks a language.
  • The choice translates the ribbon tabs, File menu, title bar, status bar and Preferences, 67 strings in all. Ribbon groups, the other dialogs and command ids stay English.

Test plan

  • Catalog tests check that ids are sorted, placeholder names match, ko-KR resolves to 한국어 while ja-JP does not, and an unknown saved code falls back to System.
  • A UI test checks that app.language ko renames the File tab to 파일 and Preferences to 환경설정, that ja is rejected, and that en brings File back.
  • cargo fmt --check, cargo clippy --workspace --all-targets -- -D warnings, assets, layers and the wasm check pass.
  • cargo test --workspace passes, apart from three font tests that already fail here because craft-fonts is not installed: symbol_font_characters_draw_in_the_sym_font, korean_composes_in_the_notes_pane and cjk_text_in_the_interface_is_drawn_with_real_glyphs.
  • On a Mac set to 한국어, launch DeckCraft and check that the tabs and File menu come up in Korean without opening Preferences.

anishguduru pushed a commit to anishguduru/deckcraft that referenced this pull request Oct 16, 2026
storytold#548)

type3_path wrote `wx 0 0 0 0 1000 1000 d1`: seven operands where d1 takes six
(wx wy llx lly urx ury). Lenient renderers (pdfium, Quartz, MuPDF, poppler) ignore the
extra one, but Acrobat treats the glyph as unusable and draws a bullet for every
character of edited Japanese (or other fallback) text. The box is now the glyph's own
bounds, rounded outward; empty glyphs (spaces) get a zero box.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The window had no string catalog, so a system language or an explicit
choice could not change what it says. Preferences now offers System,
English and 한국어. System follows a ko locale. The ribbon tabs, File
menu, title bar, status bar and Preferences use that choice. Ribbon
groups and the other dialogs stay in English.

Co-authored-by: Cursor <cursoragent@cursor.com>

@FredApps FredApps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReviewerA — source-read COMMENT (not an approval)

I read the head of the diff: Korean for the application shell, with the same shared sys-locale 0.3.2 lock hunk as the other five language PRs by this author (deckcraft#555, #543, #575, #579, #538). The same stacking point applies. The Korean catalogue needs a native reader's check against PowerPoint's Korean interface terms, and a statement of who translated it and whether a tool helped; deckcraft#804 (Korean editing) by another author touches Korean font names in the same application. I have not run it, and no exact-head CI result exists for this head. Nothing was run.

I ran nothing and have no exact-head CI result for this PR, so this is not an approval. Where a diff was long I read its code hunks rather than every generated or documentation line.

Status: waiting_author.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants