Repository navigation
Conversation
storytold#548) type3_path wrote `wx 0 0 0 0 1000 1000 d1`: seven operands where d1 takes six (wx wy llx lly urx ury). Lenient renderers (pdfium, Quartz, MuPDF, poppler) ignore the extra one, but Acrobat treats the glyph as unusable and draws a bullet for every character of edited Japanese (or other fallback) text. The box is now the glyph's own bounds, rounded outward; empty glyphs (spaces) get a zero box. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The window had no string catalog, so a system language or an explicit choice could not change what it says. Preferences now offers System, English and 한국어. System follows a ko locale. The ribbon tabs, File menu, title bar, status bar and Preferences use that choice. Ribbon groups and the other dialogs stay in English. Co-authored-by: Cursor <cursoragent@cursor.com>
477d0a0 to
d18bbde
Compare
FredApps
left a comment
There was a problem hiding this comment.
ReviewerA — source-read COMMENT (not an approval)
I read the head of the diff: Korean for the application shell, with the same shared sys-locale 0.3.2 lock hunk as the other five language PRs by this author (deckcraft#555, #543, #575, #579, #538). The same stacking point applies. The Korean catalogue needs a native reader's check against PowerPoint's Korean interface terms, and a statement of who translated it and whether a tool helped; deckcraft#804 (Korean editing) by another author touches Korean font names in the same application. I have not run it, and no exact-head CI result exists for this head. Nothing was run.
I ran nothing and have no exact-head CI result for this PR, so this is not an approval. Where a diff was long I read its code hunks rather than every generated or documentation line.
Status: waiting_author.
Summary
app.language(system,enorko).koorko-KRlocale. On the web build, System stays English until the user picks a language.Test plan
ko-KRresolves to 한국어 whileja-JPdoes not, and an unknown saved code falls back to System.app.languagekorenames the File tab to 파일 and Preferences to 환경설정, thatjais rejected, and thatenbrings File back.cargo fmt --check,cargo clippy --workspace --all-targets -- -D warnings, assets, layers and the wasm check pass.cargo test --workspacepasses, apart from three font tests that already fail here becausecraft-fontsis not installed:symbol_font_characters_draw_in_the_sym_font,korean_composes_in_the_notes_paneandcjk_text_in_the_interface_is_drawn_with_real_glyphs.